From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] d/tmpfiles: fix permission regression for /run/pve directory
Date: Tue, 05 Aug 2025 12:20:57 +0200 [thread overview]
Message-ID: <175438925746.266911.16254321466643248081@yuna.proxmox.com> (raw)
In-Reply-To: <20250805100556.40874-1-f.ebner@proxmox.com>
Quoting Fiona Ebner (2025-08-05 12:03:24)
> There is a regression regarding the permission for the /run/pve
> directory. In Proxmox VE 8, the directory had root:root 0755
> permissions, being auto-created as the lxc-syscalld runtime directory.
> In Proxmox VE 9, the permissions were restricted to root:root 0750,
> but this leads to an issue with remote migration, when pveproxy tries
> to access the mtunnel socket:
>
> pveproxy[2484]: connect to 'unix/:/run/pve/ct-112.mtunnel' failed: Permission denied
>
> Relax the permissions again by allowing the www-data group
> read-access, so that pveproxy can access the socket.
>
> This aligns the permissions with what /run/pve-cluster has.
>
> Reported-by: Hannes Laimer <h.laimer@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> debian/tmpfiles | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian/tmpfiles b/debian/tmpfiles
> index 98b8fb96..1263300f 100644
> --- a/debian/tmpfiles
> +++ b/debian/tmpfiles
> @@ -1,2 +1,2 @@
> -#Type Path Mode User Group Age Argument
> -d /run/pve 0750 root root - -
> +#Type Path Mode User Group Age Argument
> +d /run/pve 0750 root www-data - -
> --
> 2.47.2
the change itself LGTM, but note that pve-manager is lacking #DEBHELPER# in
debian/postinst, so the snippet that ensures the dir gets created at package
installation/upgrade time is missing.
FTR, the snippet looks like this:
# Automatically added by dh_installtmpfiles/13.24.2
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
if [ -x "$(command -v systemd-tmpfiles)" ]; then
systemd-tmpfiles ${DPKG_ROOT:+--root="$DPKG_ROOT"} --create pve-manager.conf || true
fi
fi
the tmpfiles config above is also lacking `z` which would ensure that the
changed ownership actually is set on upgrades, as opposed to on the next
reboot?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-05 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 10:03 Fiona Ebner
2025-08-05 10:10 ` Hannes Laimer
2025-08-05 10:20 ` Fabian Grünbichler [this message]
2025-08-05 10:36 ` Thomas Lamprecht
2025-08-05 10:24 ` [pve-devel] applied: " Thomas Lamprecht
2025-08-05 13:11 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175438925746.266911.16254321466643248081@yuna.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox