[pve-devel] [PATCH] api: sdn: ipams: status: ensure that guest ID is returned as an integer

[pve-devel] [PATCH] api: sdn: ipams: status: ensure that guest ID is returned as an integer

[Fiona Ebner]

This is a breaking API change intended for PVE 9.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Together with [0] this makes sorting numerically by guest ID work in
the SDN IPAM UI.

[0] https://lore.proxmox.com/pve-devel/2014f691-aa28-4ab4-91c1-48c1f68d8a54@proxmox.com/T/

 src/PVE/API2/Network/SDN/Ipams.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/API2/Network/SDN/Ipams.pm b/src/PVE/API2/Network/SDN/Ipams.pm
index 89e05ee..9955817 100644
--- a/src/PVE/API2/Network/SDN/Ipams.pm
+++ b/src/PVE/API2/Network/SDN/Ipams.pm
@@ -364,6 +364,8 @@ __PACKAGE__->register_method({
                     $entry->{ip} = $ip;
                     $entry->{vnet} = $vnet;
 
+                    $entry->{vmid} = int($entry->{vmid}) if defined($entry->{vmid});
+
                     push @$result, $entry;
                 }
             }
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] api: sdn: ipams: status: ensure that guest ID is returned as an integer

[Fiona Ebner]

This is for the pve-network repository. Sorry, seems like I haven't
configured the prefix for this in my git config yet.

Am 01.08.25 um 1:45 PM schrieb Fiona Ebner:
> This is a breaking API change intended for PVE 9.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Together with [0] this makes sorting numerically by guest ID work in
> the SDN IPAM UI.
> 
> [0] https://lore.proxmox.com/pve-devel/2014f691-aa28-4ab4-91c1-48c1f68d8a54@proxmox.com/T/
> 
>  src/PVE/API2/Network/SDN/Ipams.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/API2/Network/SDN/Ipams.pm b/src/PVE/API2/Network/SDN/Ipams.pm
> index 89e05ee..9955817 100644
> --- a/src/PVE/API2/Network/SDN/Ipams.pm
> +++ b/src/PVE/API2/Network/SDN/Ipams.pm
> @@ -364,6 +364,8 @@ __PACKAGE__->register_method({
>                      $entry->{ip} = $ip;
>                      $entry->{vnet} = $vnet;
>  
> +                    $entry->{vmid} = int($entry->{vmid}) if defined($entry->{vmid});
> +
>                      push @$result, $entry;
>                  }
>              }



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] api: sdn: ipams: status: ensure that guest ID is returned as an integer

[Thomas Lamprecht]

On Fri, 01 Aug 2025 13:44:45 +0200, Fiona Ebner wrote:
> This is a breaking API change intended for PVE 9.
> 
> 

Applied, thanks!

[1/1] api: sdn: ipams: status: ensure that guest ID is returned as an integer
      commit: 37c2156ce8b26d6fb5e6e173b660841eb64a83cd


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel