From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 1/2] config: net: avoid duplicate ipam entries on nic update
Date: Mon, 22 Jul 2024 18:39:07 +0200 [thread overview]
Message-ID: <1753f8eb-e07b-44ea-a331-dbfad039ee41@proxmox.com> (raw)
In-Reply-To: <20240717130603.127574-1-s.hanreich@proxmox.com>
Am 17/07/2024 um 15:06 schrieb Stefan Hanreich:
> Updating the NIC of a VM when the following conditions were met:
> * VM is turned off
> * NIC is on a bridge that uses automatic dhcp
> * Leave bridge unchanged
>
> led to duplicate IPAM entries for the same network device.
>
> This is due to the fact that the add_next_free_cidr always ran on
> applying pending network changes.
>
> Now we only add a new ipam entry if either:
> * the value of the bridge or mac address changed
> * the network device has been newly added
>
> This way no duplicate IPAM entries should get created.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> PVE/QemuServer.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-22 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 13:06 [pve-devel] " Stefan Hanreich
2024-07-17 13:06 ` [pve-devel] [PATCH pve-manager 2/2] sdn: ipam: fix editing custom mappings Stefan Hanreich
2024-07-22 16:39 ` [pve-devel] applied: " Thomas Lamprecht
2024-07-22 16:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1753f8eb-e07b-44ea-a331-dbfad039ee41@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox