From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 1/2] fix #6580: blockdev: commit: re-open target format node as writable if necessary
Date: Thu, 31 Jul 2025 14:28:02 +0200 [thread overview]
Message-ID: <175396488140.1094030.12900328190192739886.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250731104935.53039-1-f.ebner@proxmox.com>
On Thu, 31 Jul 2025 12:48:45 +0200, Fiona Ebner wrote:
> Removing the first snapshot in a snapshot-as-volume-chain is done via
> block-commit for performance reasons, rather than stream, because the
> snapshot volume, being the base, is usually larger than the delta
> since the snapshot.
>
> When a drive has the 'ro' flag set in the virtual machine
> configuration, all three nodes in the throttle->fmt->file chain are
> opened with the read-only flag set and thus the format node could not
> serve as the target for the stream operation.
>
> [...]
Applied, thanks!
[1/2] fix #6580: blockdev: commit: re-open target format node as writable if necessary
commit: f06f3a3c4a637d64bb511b53d7e17e561870c090
[2/2] blockdev: delete: delete format block node first
commit: 4a0952d985170a85c0bc60b1cd249bebb7e74cc0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-31 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 10:48 [pve-devel] " Fiona Ebner
2025-07-31 10:48 ` [pve-devel] [PATCH qemu-server 2/2] blockdev: delete: delete format block node first Fiona Ebner
2025-07-31 12:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175396488140.1094030.12900328190192739886.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox