From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH container v2 2/4] seccomp config: adapt to new lxc-syscalld runtime directory
Date: Wed, 30 Jul 2025 15:04:56 +0200 [thread overview]
Message-ID: <1753880643.tybj4ylg1v.astroid@yuna.none> (raw)
In-Reply-To: <98fcd5ca-9e5c-47d5-8129-240c3dbc50bb@proxmox.com>
On July 30, 2025 3:00 pm, Thomas Lamprecht wrote:
> Am 30.07.25 um 14:50 schrieb Fabian Grünbichler:
>>> For already running containers, a symbolic link is put into place by
>>> the new version of pve-lxc-syscalld, but newly started ones should
>>> always use the new socket path as soon as it is available. Only use
>>> the old socket path if the old version of pve-lxc-syscalld is still
>>> used. The heuristic to check this is:
>>> 1. the new socket path doesn't exist
>>> 2. the old socket path exists
>>> 3. the old socket path is not a symbolic link
>> couldn't this be solved by adding a versioned depends, instead of
>> breaking the other direction which is not actually required because of
>> the compat symlink?
>
>
> The compat symlink only exists for the boot during which the upgrade
> to the newer pve-lxc-syscalld was made, afterwards the new syscalld
> really breaks older pve-container.
right!
so that only leaves new pve-manager combined with old pve-lxc-syscalld
as problematic combination, but that is no worse than the status quo
(restarting the syscalld service still clears out /run/pve).
LGTM!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-30 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 14:40 [pve-devel] [PATCH-SERIES manager/container/lxc-syscalld v2 0/4] avoid using generic runtime directory name for pve-lxc-syscalld Fiona Ebner
2025-07-23 14:40 ` [pve-devel] [PATCH manager v2 1/4] debian: add tpmfiles.d config to create /run/pve directory Fiona Ebner
2025-07-30 23:21 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-23 14:40 ` [pve-devel] [PATCH container v2 2/4] seccomp config: adapt to new lxc-syscalld runtime directory Fiona Ebner
2025-07-30 12:50 ` Fabian Grünbichler
2025-07-30 13:00 ` Thomas Lamprecht
2025-07-30 13:04 ` Fabian Grünbichler [this message]
2025-07-30 13:18 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-23 14:40 ` [pve-devel] [PATCH pve-lxc-syscalld v2 3/4] service: avoid using generic runtime directory name Fiona Ebner
2025-07-30 23:33 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-23 14:40 ` [pve-devel] [PATCH pve-lxc-syscalld v2 4/4] d/postinst: create link to new socket location on upgrade Fiona Ebner
2025-07-30 23:33 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1753880643.tybj4ylg1v.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox