public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied: [PATCH ha-manager] watchdog-mux: Restore if guard for watchdog updates
Date: Tue, 29 Jul 2025 21:38:48 +0200	[thread overview]
Message-ID: <175381792664.2698234.4111003785738083319.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250723105518.272549-1-m.sandoval@proxmox.com>

On Wed, 23 Jul 2025 12:54:37 +0200, Maximiliano Sandoval wrote:
> In commit c26b474 the if condition was removed in favor of the if guard
> on the higher level. However, this introduced functional change, the
> watchdog now updates immediately after update_watchdog is set to 0,
> potentially causing fencing after x+1 seconds instead of x seconds. This
> behavior is incorrect because updating the watchdog after declaring no
> more updates makes no logical sense.
> 
> [...]

Applied, thanks!

[1/1] watchdog-mux: Restore if guard for watchdog updates
      commit: 1700789e47b516d560e03aade6d6a49a425a8789


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-07-29 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 10:54 [pve-devel] " Maximiliano Sandoval
2025-07-23 10:58 ` Maximiliano Sandoval
2025-07-29 19:38 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175381792664.2698234.4111003785738083319.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal