From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-storage v3] fix #6561: zfspool: track refquota for subvolumes via user properties
Date: Tue, 29 Jul 2025 15:18:54 +0200 [thread overview]
Message-ID: <175379503278.87783.2118363966780967203.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250729121151.159797-1-s.sterz@proxmox.com>
On Tue, 29 Jul 2025 14:11:51 +0200, Shannon Sterz wrote:
> zfs itself does not track the refquota per snapshot so we need handle
> this ourselves. otherwise rolling back a volume that has been resize
> since the snapshot, will retain the new size. this is problematic, as
> it means the value in the guest config does not longer match the size
> of the disk on the storage.
>
> this implementation tries to do so by leveraging a user property per
> snapshot.
>
> [...]
Applied, thanks! Fixed up the capitalization in the commit message and
made some minor wording changes.
[1/1] fix #6561: zfspool: track refquota for subvolumes via user properties
commit: a9315a0ed32293d11a56470d2e19598a5212e8e3
> keeping fiona's R-b from v2 as v3 basically just incorporates her
> suggestions (or suggestions she signed off on), but i'd drop the T-b
> as these patches now behave somewhat differently (warning on unknown
> values).
Personally, I prefer if the R-b is dropped if there are non-trivial
changes and that such earlier reviews are rather mentioned as part of
the changelog for context.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-29 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 12:11 [pve-devel] " Shannon Sterz
2025-07-29 13:18 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175379503278.87783.2118363966780967203.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox