From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2 0/4] improvements to proxmox-network-interface-pinning
Date: Tue, 29 Jul 2025 09:38:09 +0200 [thread overview]
Message-ID: <175377468888.1957591.4182790303711225669.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250724093459.76397-1-s.hanreich@proxmox.com>
On Thu, 24 Jul 2025 11:34:55 +0200, Stefan Hanreich wrote:
> Several improvements to the network interface pinning tool:
> * interfaces are now iterated according to ifindex
> * output of the mapping is now sorted and less verbose
> * users can now set a specific target name
> * if has been introduced as an additional legal prefix
>
> Still looking into removing the PHYSICAL_NIC_RE altogether, but sending this
> patch series as-is nevertheless for review / feedback. If I manage to remove the
> PHYSICAL_NIC_RE in time, we could get rid of the constraints of prefix /
> target-name altogether...
>
> [...]
Applied, thanks!
Made two small follow-up commits, one to adapt the 'prefix' parameter
description (was copied from the interface parameter) and replacing the
explicit check for the target-name -> interface parameter dependency with the
built-in support from our JSON schema implementation.
[1/4] network-interface-pinning: use ifindex as order for pinning
commit: 595b69b02474e7ad8d159cf757249a691c1f7ebb
[2/4] network-interface-pinning: improve printing mapping
commit: e19c1f48b5d747eb0232e6616e2c938271bf3924
[3/4] network-interface-pinning: add target-name parameter
commit: 63dddce3cb7c7b4adae5897376bf4aa09b14d61b
[4/4] network-interface-pinning: add if prefix to list of allowed prefixes
commit: 90057e0ab947804704de91dccab7b8d2b219373f
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-29 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 9:34 [pve-devel] " Stefan Hanreich
2025-07-24 9:34 ` [pve-devel] [PATCH pve-manager v2 1/4] network-interface-pinning: use ifindex as order for pinning Stefan Hanreich
2025-07-24 9:34 ` [pve-devel] [PATCH pve-manager v2 2/4] network-interface-pinning: improve printing mapping Stefan Hanreich
2025-07-24 9:34 ` [pve-devel] [PATCH pve-manager v2 3/4] network-interface-pinning: add target-name parameter Stefan Hanreich
2025-07-24 9:34 ` [pve-devel] [PATCH pve-manager v2 4/4] network-interface-pinning: add if prefix to list of allowed prefixes Stefan Hanreich
2025-07-29 7:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175377468888.1957591.4182790303711225669.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox