* [pve-devel] [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation
@ 2025-07-28 15:10 Friedrich Weber
2025-07-28 15:10 ` [pve-devel] [PATCH manager 2/2] pve8to9: lvm: fix missing space and remove unnecessary line break Friedrich Weber
2025-07-29 6:00 ` [pve-devel] applied: [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Friedrich Weber @ 2025-07-28 15:10 UTC (permalink / raw)
To: pve-devel
In some cases, autoactivation was spelled as "auto-activation". Remove
the dash for consistency with other occurrences and the LVM
documentation.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
PVE/CLI/pve8to9.pm | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index fec89a7c..a6ea3f82 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1631,11 +1631,11 @@ sub check_lvm_autoactivation {
my $autoactivated_guest_lvs =
query_autoactivated_lvm_guest_volumes($cfg, $storeid, $vgname);
if (scalar(@$autoactivated_guest_lvs) > 0) {
- log_notice("storage '$storeid' has guest volumes with auto-activation enabled");
+ log_notice("storage '$storeid' has guest volumes with autoactivation enabled");
$needs_fix = 1;
$shared_affected = 1 if $info->{shared};
} else {
- log_pass("all guest volumes on storage '$storeid' have auto-activation disabled");
+ log_pass("all guest volumes on storage '$storeid' have autoactivation disabled");
}
}
if ($needs_fix) {
@@ -1644,13 +1644,13 @@ sub check_lvm_autoactivation {
my $extra =
$shared_affected
? "Some affected volumes are on shared LVM storages, which has known issues (Bugzilla"
- . " #4997). Disabling auto-activation for those is strongly recommended!"
- : "All volumes with auto-activations reside on local storage, where this normally does"
+ . " #4997). Disabling autoactivation for those is strongly recommended!"
+ : "All volumes with autoactivations reside on local storage, where this normally does"
. " not causes any issues.";
$_log->(
- "Starting with PVE 9, auto-activation will be disabled for new LVM/LVM-thin guest"
- . " volumes. This system has some volumes that still have auto-activation enabled. "
- . "$extra\nYou can run the following command to disable auto-activation for existing"
+ "Starting with PVE 9, autoactivation will be disabled for new LVM/LVM-thin guest"
+ . " volumes. This system has some volumes that still have autoactivation enabled. "
+ . "$extra\nYou can run the following command to disable autoactivation for existing"
. "LVM/LVM-thin "
. "guest volumes:" . "\n\n"
. "\t/usr/share/pve-manager/migrations/pve-lvm-disable-autoactivation"
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH manager 2/2] pve8to9: lvm: fix missing space and remove unnecessary line break
2025-07-28 15:10 [pve-devel] [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation Friedrich Weber
@ 2025-07-28 15:10 ` Friedrich Weber
2025-07-29 6:00 ` [pve-devel] applied: [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Friedrich Weber @ 2025-07-28 15:10 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
PVE/CLI/pve8to9.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index a6ea3f82..d1a5349f 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1651,8 +1651,7 @@ sub check_lvm_autoactivation {
"Starting with PVE 9, autoactivation will be disabled for new LVM/LVM-thin guest"
. " volumes. This system has some volumes that still have autoactivation enabled. "
. "$extra\nYou can run the following command to disable autoactivation for existing"
- . "LVM/LVM-thin "
- . "guest volumes:" . "\n\n"
+ . " LVM/LVM-thin guest volumes:\n\n"
. "\t/usr/share/pve-manager/migrations/pve-lvm-disable-autoactivation"
. "\n");
}
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation
2025-07-28 15:10 [pve-devel] [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation Friedrich Weber
2025-07-28 15:10 ` [pve-devel] [PATCH manager 2/2] pve8to9: lvm: fix missing space and remove unnecessary line break Friedrich Weber
@ 2025-07-29 6:00 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-07-29 6:00 UTC (permalink / raw)
To: pve-devel, Friedrich Weber
On Mon, 28 Jul 2025 17:10:48 +0200, Friedrich Weber wrote:
> In some cases, autoactivation was spelled as "auto-activation". Remove
> the dash for consistency with other occurrences and the LVM
> documentation.
>
>
Applied, thanks!
[1/2] pve8to9: lvm: use consistent spelling for autoactivation
commit: 2e2ba120ee84087d6874d8e19a7b65497bc531f9
[2/2] pve8to9: lvm: fix missing space and remove unnecessary line break
commit: 0d02c18524079496c0914a54c81cf68a4489d45b
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-29 5:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-28 15:10 [pve-devel] [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation Friedrich Weber
2025-07-28 15:10 ` [pve-devel] [PATCH manager 2/2] pve8to9: lvm: fix missing space and remove unnecessary line break Friedrich Weber
2025-07-29 6:00 ` [pve-devel] applied: [PATCH manager 1/2] pve8to9: lvm: use consistent spelling for autoactivation Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox