From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] plugin: volume snapshot info: untaint snapshot filename
Date: Mon, 28 Jul 2025 15:20:18 +0200 [thread overview]
Message-ID: <175370877620.504564.7753383391351285866.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250725154936.281471-1-f.weber@proxmox.com>
On Fri, 25 Jul 2025 17:48:57 +0200, Friedrich Weber wrote:
> Without untainting, offline-deleting a volume-chain snapshot on a
> directory storage via the GUI fails with an "Insecure dependecy in
> exec [...]" error, because volume_snapshot_delete uses the filename
> its qemu-img invocation.
>
>
Applied, thanks - this filename here is always absolute, even if we
fix up more of the actual referencing to happen via relative paths.
[1/1] plugin: volume snapshot info: untaint snapshot filename
commit: 93f0dfbc756e02984d85d5f301314b987d8388f1
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-28 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 15:48 [pve-devel] " Friedrich Weber
2025-07-28 9:59 ` Fabian Grünbichler
2025-07-28 11:08 ` Fiona Ebner
2025-07-28 12:21 ` Fabian Grünbichler
2025-07-28 13:30 ` Friedrich Weber
2025-07-28 13:32 ` Friedrich Weber
2025-07-31 12:37 ` Friedrich Weber
2025-07-31 12:55 ` Fiona Ebner
2025-07-28 13:20 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175370877620.504564.7753383391351285866.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox