public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-manager 1/1] network-interface-pinning: fix pinning for bond members
@ 2025-07-22 15:14 Stefan Hanreich
  2025-07-23 17:31 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hanreich @ 2025-07-22 15:14 UTC (permalink / raw)
  To: pve-devel

The key in the ip link output is actually called linkinfo. Before this
patch, members of bond interfaces that inherit the MAC address of the
bond would have a wrong MAC in their generated .link file.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 PVE/CLI/proxmox_network_interface_pinning.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm
index 382e2d94b..7f4e9f0ff 100644
--- a/PVE/CLI/proxmox_network_interface_pinning.pm
+++ b/PVE/CLI/proxmox_network_interface_pinning.pm
@@ -301,7 +301,7 @@ sub get_ip_link_mac {
 
     # members of bonds can have a different MAC than the physical interface, so
     # we need to check if they're enslaved
-    return $ip_link->{link_info}->{info_slave_data}->{perm_hwaddr} // $ip_link->{address};
+    return $ip_link->{linkinfo}->{info_slave_data}->{perm_hwaddr} // $ip_link->{address};
 }
 
 sub get_ip_links {
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH pve-manager 1/1] network-interface-pinning: fix pinning for bond members
  2025-07-22 15:14 [pve-devel] [PATCH pve-manager 1/1] network-interface-pinning: fix pinning for bond members Stefan Hanreich
@ 2025-07-23 17:31 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-07-23 17:31 UTC (permalink / raw)
  To: pve-devel, Stefan Hanreich

On Tue, 22 Jul 2025 17:14:52 +0200, Stefan Hanreich wrote:
> The key in the ip link output is actually called linkinfo. Before this
> patch, members of bond interfaces that inherit the MAC address of the
> bond would have a wrong MAC in their generated .link file.
> 
> 

Applied, thanks!

[1/1] network-interface-pinning: fix pinning for bond members
      commit: 8694ab3ceae3a53bba3e422a78f6878250253997


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-23 17:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-22 15:14 [pve-devel] [PATCH pve-manager 1/1] network-interface-pinning: fix pinning for bond members Stefan Hanreich
2025-07-23 17:31 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal