From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-common 1/1] inotify/interfaces: use 'ip link' instead of /proc/net/dev
Date: Wed, 23 Jul 2025 17:02:31 +0200 [thread overview]
Message-ID: <175328294843.3720382.10504362558256531970.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250723142106.235104-1-s.hanreich@proxmox.com>
On Wed, 23 Jul 2025 16:21:06 +0200, Stefan Hanreich wrote:
> The function reading /etc/network/interfaces used /proc/net/dev to
> determine pre-existing physical interfaces. Since the introduction of
> altnames, /proc/net/dev returns insufficient information for
> determining if an interface is already contained in /e/n/i, since it
> does not include altnames.
>
> The interfaces parser added all interfaces from /proc/net/dev as
> configurable network devices. If altnames were used in the
> configuration, then the same interface would be listed twice: once
> with its 'real' name (from /proc/net/dev) and once with its altname
> (from the interfaces file).
>
> [...]
I tested this one some configurations where /e/n/i used different names
compared to the "primary" interface name the kernels uses, made it work fine
now. Implementation wise it looks relative straight forward.
I do not recall for sure anymore, but do differing bridge-ports work
transparently with the ifupdown2 changes from Christoph. With that it might be
nice to support it here too in the midterm, but that is certainly not a blocker
for now.
Applied with perltidy formatting changes squashed in, thanks!
[1/1] inotify/interfaces: use 'ip link' instead of /proc/net/dev
commit: 346ff9744b036c529373cab5b503eaaf37a5bf03
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 14:21 [pve-devel] " Stefan Hanreich
2025-07-23 15:02 ` Thomas Lamprecht [this message]
2025-07-23 15:16 ` [pve-devel] applied: " Stefan Hanreich
2025-07-23 15:33 ` Thomas Lamprecht
2025-07-23 15:53 ` Stefan Hanreich
2025-07-23 15:57 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175328294843.3720382.10504362558256531970.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox