From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] blockdev: also set read-only flag on top throttle node
Date: Tue, 22 Jul 2025 18:10:29 +0200 [thread overview]
Message-ID: <175320062712.1749140.8143788964706302076.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250718154503.179257-1-f.ebner@proxmox.com>
On Fri, 18 Jul 2025 17:44:57 +0200, Fiona Ebner wrote:
> QEMU will try to set the write permission on a device even if it's
> just the throttle filter that is not marked as read-only. This causes
> VM start to fail when a drive with the Proxmox VE-specific 'ro' flag
> is configured and also template backup. Properly set the flag also
> for the top throttle node.
>
>
> [...]
Applied, thanks!
FWIW, I shortly thought about if it makes sense to only add the read-only param
if it's true, to avoid adding extra "bloat" to the CLI, but it's not _that_
much more and being more expressive might pay off, so I kept it as is.
[1/1] blockdev: also set read-only flag on top throttle node
commit: d763b72462d777b908237014b868e5009c902b57
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-22 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 15:44 [pve-devel] " Fiona Ebner
2025-07-22 16:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175320062712.1749140.8143788964706302076.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox