From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v2] feat: ios: enable opening of virt-viewer (.vv) file with spice app
Date: Tue, 22 Jul 2025 11:24:05 +0200 [thread overview]
Message-ID: <175317618694.896125.6726848147358802802.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250721134643.62745-1-s.shaji@proxmox.com>
On Mon, 21 Jul 2025 15:46:43 +0200, Shan Shaji wrote:
> The feature to open the spice connection file was disabled in iOS and
> was only available in Android. To support iOS, a new native channel
> implementation for iOS has been added.
>
> For the iOS implementation, use the `UIActivityViewController` [0] to
> show the share sheet with the suggested apps that can open the file.
> Alternatively, users can also save the file to the device storage.
>
> [...]
Applied, but had to fixup quite a few whitespace issues [0] please ensure the
code is correctly formated the next time, thanks!
[0]: e.g. git am complains about:
Applying: feat: ios: enable opening of virt-viewer (.vv) file with spice app
pve_flutter_frontend/.git/rebase-apply/patch:36: trailing whitespace.
pve_flutter_frontend/.git/rebase-apply/patch:39: trailing whitespace.
pve_flutter_frontend/.git/rebase-apply/patch:44: trailing whitespace.
pve_flutter_frontend/.git/rebase-apply/patch:48: trailing whitespace.
pve_flutter_frontend/.git/rebase-apply/patch:55: trailing whitespace.
[1/1] feat: ios: enable opening of virt-viewer (.vv) file with spice app
commit: 826474c276a051077c4e10ca3bc818eb78e247c4
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-22 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 13:46 [pve-devel] " Shan Shaji
2025-07-22 9:24 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175317618694.896125.6726848147358802802.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox