* [pve-devel] [PATCH] fabrics: add maxLength to fabric name to improve error message
@ 2025-07-18 12:02 Gabriel Goller
2025-07-18 12:10 ` Gabriel Goller
2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Gabriel Goller @ 2025-07-18 12:02 UTC (permalink / raw)
To: pve-devel
A fabric name has a character limit of 8 characters. (This is due to the
dummy interface, which is named 'dummy_<fabric_name>' which is limited
by the max interface name length in the kernel.) This shows a nicer
error message instead of only "Invalid character".
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
www/manager6/sdn/fabrics/FabricEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index 5aa001564175..07d1692879c7 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -18,6 +18,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
xtype: 'proxmoxtextfield',
fieldLabel: gettext('Name'),
labelWidth: 120,
+ maxLength: 8,
name: 'id',
cbind: {
disabled: '{!isCreate}',
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH] fabrics: add maxLength to fabric name to improve error message
2025-07-18 12:02 [pve-devel] [PATCH] fabrics: add maxLength to fabric name to improve error message Gabriel Goller
@ 2025-07-18 12:10 ` Gabriel Goller
2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Gabriel Goller @ 2025-07-18 12:10 UTC (permalink / raw)
To: pve-devel
Forgot to add the repository in the header, this goes to pve-manager.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH] fabrics: add maxLength to fabric name to improve error message
2025-07-18 12:02 [pve-devel] [PATCH] fabrics: add maxLength to fabric name to improve error message Gabriel Goller
2025-07-18 12:10 ` Gabriel Goller
@ 2025-07-18 12:45 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-07-18 12:45 UTC (permalink / raw)
To: pve-devel, Gabriel Goller
On Fri, 18 Jul 2025 14:02:13 +0200, Gabriel Goller wrote:
> A fabric name has a character limit of 8 characters. (This is due to the
> dummy interface, which is named 'dummy_<fabric_name>' which is limited
> by the max interface name length in the kernel.) This shows a nicer
> error message instead of only "Invalid character".
>
>
Applied, thanks!
[1/1] fabrics: add maxLength to fabric name to improve error message
commit: 9663f410c5be9f599d13a53c45f62ec77b105a22
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-18 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-18 12:02 [pve-devel] [PATCH] fabrics: add maxLength to fabric name to improve error message Gabriel Goller
2025-07-18 12:10 ` Gabriel Goller
2025-07-18 12:45 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox