From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] tools: dump logfile: fix result type in case the file cannot be opened
Date: Thu, 17 Jul 2025 21:27:14 +0200 [thread overview]
Message-ID: <175278043348.50117.12048004201744201670.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250717165006.106126-1-f.weber@proxmox.com>
On Thu, 17 Jul 2025 18:50:01 +0200, Friedrich Weber wrote:
> The second return value of dump_logfile should be a reference to an
> array of hash references (one per log line), but in case the file
> cannot be opened, it currently directly returns a reference to a hash.
>
> As a result, the /nodes/{node}/tasks/{upid}/log endpoint response does
> not match the schema in case the task log cannot be opened (for
> example, does not exist). This was reported in enterprise support, as
> it trips up external monitoring tools that query this endpoint.
>
> [...]
Applied, thanks!
[1/1] tools: dump logfile: fix result type in case the file cannot be opened
(no commit info)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-17 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 16:50 [pve-devel] " Friedrich Weber
2025-07-17 19:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175278043348.50117.12048004201744201670.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox