From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Hannes Duerr <h.duerr@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-network 1/2] dhcp: make plugin types query from Dhcp.pm possible
Date: Thu, 17 Jul 2025 00:40:03 +0200 [thread overview]
Message-ID: <175270551516.3525301.15640463987163163044.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250711095206.30852-1-h.duerr@proxmox.com>
On Fri, 11 Jul 2025 11:52:05 +0200, Hannes Duerr wrote:
> At the moment it is possible to query the Dhcp plugin types from the
> `use PVE::Network::SDN::Dhcp::Plugin` without importing
> `PVE::Network::SDN::Dhcp`. In consequence the section config is not
> created although one would have been expected it to be created.
>
> Importing `use pve::network::sdn::Dhcp` would solve the issue, but since
> this is not a nice pattern and in order to avoid such problems in the
> future, we are now making it possible to query the plugin type from
> DHCP. If you then import DHCP, the section config will be built
> correctly.
>
> [...]
Applied, thanks!
[1/2] dhcp: make plugin types query from Dhcp.pm possible
commit: e78d25b
[2/2] dhcp: remove unused SubnetPlugin import
commit: 0d455b9
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-16 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:52 [pve-devel] " Hannes Duerr
2025-07-11 9:52 ` [pve-devel] [PATCH pve-network 2/2] dhcp: remove unused SubnetPlugin import Hannes Duerr
2025-07-16 7:43 ` [pve-devel] [PATCH pve-network 1/2] dhcp: make plugin types query from Dhcp.pm possible Friedrich Weber
2025-07-16 22:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175270551516.3525301.15640463987163163044.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox