public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [pbs-devel] [PATCH proxmox{,-backup} 00/10] change of default notification-mode; UX improvements
Date: Wed, 16 Jul 2025 01:13:57 +0200	[thread overview]
Message-ID: <175262123356.2483549.12450486800693212153.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250623141315.288681-1-l.wagner@proxmox.com>

On Mon, 23 Jun 2025 16:13:05 +0200, Lukas Wagner wrote:
> This is intended for the PBS 4.0 release (trixie based).
> 
> This patch series changes the default notification mode for PBS to
> 'notification-system' from the former default of 'legacy-sendmail'.
> 
> The rationale for the new default is:
>   - 'notification-system' was already used as a default for any datastore
>     created by the GUI
>   - consistency, since on PVE, the default is 'auto' (which does not exist
>     on PBS, but is equivalent to 'notification-system' unless an email
>     address has been added as well)
>   - users are gently nudged to use the new notification stack
> 
> [...]

With a trivial merge conflict in the context of the first patch resolved:

Applied, thanks!

As replied, and you correctly noted already, the old migrate-config command for
prune jobs can now go, but IMO still does not hurt to have a dedicated command
group, and it also doesn't hurt if we keep it a bit longer, we can now remove
it at any time after all.

[01/9] cli: manager: move update-to-prune-jobs command to new migrate-config sub-command
       commit: 9526aee10a0c1b86de70a5d775a7f7cac048ced0
[02/9] cli: manager: add 'migrate-config default-notification-mode' command
       commit: 243e6a57841839e4f00c15e3997bb7a1cf7d86d3
[PATCH 3/9] d/postinst: migrate notification mode default on update
       commit: 93390b67df34db664e174f706ac71e02a3d477d5
[04/9] ui: datastore options view: switch to new notification-mode default
       commit: 20053ec2160f861cade003cb72cd66396c84985a
[05/9] ui: tape backup job: move notification settings to a separate tab
       commit: 025afdb9fee735fd23e93b6889298c44dd8e3909
[06/9] ui: one-shot tape backup: use same wording as tape-backup jobs
       commit: 82963b7d4b93992dce3c92ae8ae937301a773515
[07/9] ui: datastore options: notifications: use same jargon as tape-jobs and PVE
       commit: 0471464f4e9a7857b3d5042014ef3b47ad3d979f
[08/9] ui: datastore options: drop notify and notify-user rows
       commit: 00290872a3787f31578247902960d82ea72b69ad
[09/9] ui: datastore options: notification: use radio controls to select mode
       commit: b289d294c879376853586221b984290928f0f0f1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-07-15 23:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250623141315.288681-1-l.wagner@proxmox.com>
     [not found] ` <20250623141315.288681-2-l.wagner@proxmox.com>
2025-07-15 22:47   ` [pve-devel] applied: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: change default notification mode to 'notification-system' Thomas Lamprecht
2025-07-15 23:13 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175262123356.2483549.12450486800693212153.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal