[pve-devel] applied: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: change default notification mode to 'notification-system'

[pve-devel] applied: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: change default notification mode to 'notification-system'

[Thomas Lamprecht]

On Mon, 23 Jun 2025 16:13:06 +0200, Lukas Wagner wrote:
> The former default was chose avoid breaking changes during a minor
> release, but with the upcoming major release we can change the default.
> 
> The rationale for the new default is:
>   - 'notification-system' was already used as a default for any datastore
>     created by the GUI
>   - consistency, since on PVE, the default is 'auto' (which does not exist
>     on PBS, but is equivalent to 'notification-system' unless an email
>     address has been added as well)
>   - users are gently nudged to use the new notification stack
> 
> [...]

Applied this one for now, thanks!

[1/1] pbs-api-types: change default notification mode to 'notification-system'
      commit: 982eca008a1a85abdd9bc6f531cc1a4ac4e625ca


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [pbs-devel] [PATCH proxmox{,-backup} 00/10] change of default notification-mode; UX improvements

[Thomas Lamprecht]

On Mon, 23 Jun 2025 16:13:05 +0200, Lukas Wagner wrote:
> This is intended for the PBS 4.0 release (trixie based).
> 
> This patch series changes the default notification mode for PBS to
> 'notification-system' from the former default of 'legacy-sendmail'.
> 
> The rationale for the new default is:
>   - 'notification-system' was already used as a default for any datastore
>     created by the GUI
>   - consistency, since on PVE, the default is 'auto' (which does not exist
>     on PBS, but is equivalent to 'notification-system' unless an email
>     address has been added as well)
>   - users are gently nudged to use the new notification stack
> 
> [...]

With a trivial merge conflict in the context of the first patch resolved:

Applied, thanks!

As replied, and you correctly noted already, the old migrate-config command for
prune jobs can now go, but IMO still does not hurt to have a dedicated command
group, and it also doesn't hurt if we keep it a bit longer, we can now remove
it at any time after all.

[01/9] cli: manager: move update-to-prune-jobs command to new migrate-config sub-command
       commit: 9526aee10a0c1b86de70a5d775a7f7cac048ced0
[02/9] cli: manager: add 'migrate-config default-notification-mode' command
       commit: 243e6a57841839e4f00c15e3997bb7a1cf7d86d3
[PATCH 3/9] d/postinst: migrate notification mode default on update
       commit: 93390b67df34db664e174f706ac71e02a3d477d5
[04/9] ui: datastore options view: switch to new notification-mode default
       commit: 20053ec2160f861cade003cb72cd66396c84985a
[05/9] ui: tape backup job: move notification settings to a separate tab
       commit: 025afdb9fee735fd23e93b6889298c44dd8e3909
[06/9] ui: one-shot tape backup: use same wording as tape-backup jobs
       commit: 82963b7d4b93992dce3c92ae8ae937301a773515
[07/9] ui: datastore options: notifications: use same jargon as tape-jobs and PVE
       commit: 0471464f4e9a7857b3d5042014ef3b47ad3d979f
[08/9] ui: datastore options: drop notify and notify-user rows
       commit: 00290872a3787f31578247902960d82ea72b69ad
[09/9] ui: datastore options: notification: use radio controls to select mode
       commit: b289d294c879376853586221b984290928f0f0f1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel