[pve-devel] applied: [PATCH proxmox-widget-toolkit 1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On Fri, 27 Jun 2025 14:13:37 +0200, Lukas Wagner wrote:
> When editing an SMTP endpoint that has no authentication settings, in
> Chromium-based browsers, the 'Authenticate' checkbox was ticked because
> of a race condition between the view-model default and the InputPanel
> logic setting the existing values for the endpoint. Explicitly setting
> the value in the view model in onSetValues seems to fix this reliably.
> 
> Tested on:
>   - Firefox 140
>   - Chromium 137
>   - Chrome 138
>   - Gnome Web (Webkit-based) 48
> 
> [...]

Applied, thanks!

btw. adding a cover-letter to any series with a few patches might be nice in
any case, as that allows replying with R-b/T-b on that and make it clarify
that they should be applied to the whole series to both devs and b4, the
cover-letter itself can be very basic.
Here I applied Michael's trailer to all patches and Maximiliano just to the
one he replied too, as it would be fiting for him to review translation
stuff, so I figured it's really just for that part.

[1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium
      commit: ca138ff8d0dc8687ddfe9e4e448342e1fe1fb8a0
[2/3] notification: smtp: only show 'Unchanged' in password field when it makes sense
      commit: f47eec10122e5e8a25f5d76411cbef9d18ebc022
[3/3] notification: smtp: don't split translatable string
      commit: dc5d616d72e41b805155165aeb1c81c7fe7d058c


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel