From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 storage 1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option
Date: Tue, 15 Jul 2025 17:54:53 +0200 [thread overview]
Message-ID: <175259489071.2125750.147329651536741991.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250605111109.52712-1-f.ebner@proxmox.com>
On Thu, 05 Jun 2025 13:11:08 +0200, Fiona Ebner wrote:
> Use '/dev/zvol' as a base path for new storages for providers 'iet'
> and 'LIO', because that is what modern distributions use.
>
> This is a breaking change regarding the addition of new storages on
> older distributions, but it's enough to specify the base path '/dev'
> explicitly for setups that require it.
>
> [...]
Mario brought my attention to this series, so given that Christoph already
tested it and it seems relatively straight-forward I rebased on perltidy'd
master and applied, thanks!
FWIW, I shortly pondered about potential implications for allowing users with
Datastore.Allocate permission to pass an arbitrary absolute path here, but
that's really no precedent for storage plugins (e.g., DirPlugin), so I do not
think that warrants any special handling here.
[1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option
commit: d181d0b1eea1ba77a3cbf970d0e076e916ea676f
[2/2] zfs over iscsi: on-add hook: dynamically determine base path
commit: 4fb733a9ac870348511e0d9da5bf90e3278a651a
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-15 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:11 [pve-devel] " Fiona Ebner
2025-06-05 11:11 ` [pve-devel] [PATCH v3 storage 2/2] zfs over iscsi: on-add hook: dynamically determine base path Fiona Ebner
2025-07-15 15:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175259489071.2125750.147329651536741991.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox