[pve-devel] applied-series: [PATCH docs/installer v5 0/9] add early disk and network sanity checks

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, "Michael Köppl" <m.koeppl@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH docs/installer v5 0/9] add early disk and network sanity checks
Date: Tue, 15 Jul 2025 15:08:08 +0200	[thread overview]
Message-ID: <175258488499.1962316.11220902018312192834.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250715094021.154914-1-m.koeppl@proxmox.com>

On Tue, 15 Jul 2025 11:40:12 +0200, Michael Köppl wrote:
> The goal of this series is to add additional sanity checks to the
> auto-installer and the TUI and GUI installers. The following checks were
> added:
> * Btrfs / ZFS RAID: check if the required number of disks is available
> * LVM: check if swapsize < hdsize
> * Duplicate disks in answer file disk selection
> * Networking: check if IPv4 address is valid within subnet (RFC)
> 
> [...]

Applied, thanks! I loosened the restriction of being able to use a maximum
of 1/8-hdsize as swap to a maximum of 1/2, to avoid artificial limitations
without much value, as while such a relative big amount of swap is probably
rather odd in anyway, it can work and there _are_ odd use cases, so let's
not be overly strict.

[1/1] installation: remove maxroot size requirement and mention default instead
      commit: 3560f5f879f43f788e9237dc270bc2147790962b
[2/8] move RAID setup checks to RAID level enum implementations
      commit: af6d3657bb4e341a74461520ff890ecfeba34d59
[1/8] auto: add early answer file sanity check for RAID configurations
      commit: aa761eb884eb667ffc9d30266797f87b1325a385
[4/8] auto: add check for duplicate disks in answer file
      commit: 782b397a050562cc67bcea72e69799836b62ea45
[5/8] common: add more descriptive errors for invalid network configs
      commit: 4215c27adb4e75789b44ddfbcd6152bbde31dba6
[6/8] tui: change get_value return type for easier error handling
      commit: 6d0eb1588f4906570205d86b8e5e46f4e19352ce
[7/8] common: add checks for valid subnet mask and IPv4 address within subnet
      commit: e06e64c020dc4d0adcb7ceefbe658e2554da567a
[8/8] tui, gui: streamline error messages around disk and RAID checks
      commit: ceed3293619c1793fb5c3a79ad137e24b51c2238

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel