[pve-devel] [pve-installer v2] run-env: filter out interfaces without valid mac address

[pve-devel] [pve-installer v2] run-env: filter out interfaces without valid mac address

[Christian Ebner]

The installer assumes to have a valid mac address for all interfaces
as provided by the runtime env json file. Deserialization will fail
if this is not the case.

In some cases, the interface might however not provide a valid MAC
address, for example the WWAN LTE module without any SIM installed on
some laptops.

Filter out these interfaces and log this, as they cannot be correctly
used anyways.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 1 (thanks @Gabriel for the swift comment):
- Filter out interface instead of setting mac to all zero

 Proxmox/Install/RunEnv.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
index e4f0eb0..cdd7992 100644
--- a/Proxmox/Install/RunEnv.pm
+++ b/Proxmox/Install/RunEnv.pm
@@ -90,6 +90,10 @@ my sub query_netdevs : prototype() {
             $if->@{qw(ifindex ifname operstate address addr_info)};
 
         next if !$name || $name eq 'lo'; # could also check flags for LOOPBACK..
+        if (!$mac) {
+            log_info("skipped interface $name, no mac address detected");
+            next;
+        }
 
         my @valid_addrs;
         if (uc($state) eq 'UP') {
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] superseded: [pve-installer v2] run-env: filter out interfaces without valid mac address

[Christian Ebner]

superseded-by RFC version 3:
https://lore.proxmox.com/pve-devel/20250711153404.995040-1-c.ebner@proxmox.com/T/#u


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [pve-installer v2] run-env: filter out interfaces without valid mac address

[Thomas Lamprecht]

On Fri, 11 Jul 2025 11:00:35 +0200, Christian Ebner wrote:
> The installer assumes to have a valid mac address for all interfaces
> as provided by the runtime env json file. Deserialization will fail
> if this is not the case.
> 
> In some cases, the interface might however not provide a valid MAC
> address, for example the WWAN LTE module without any SIM installed on
> some laptops.
> 
> [...]

Agreeing with your assesment in the reply to v3, so applied this one, thanks!

[1/1] run-env: filter out interfaces without valid mac address
      commit: aff57231b3bf18d778deb9ff596aeb1b79048ecf


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel