public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [pve-installer v2] run-env: filter out interfaces without valid mac address
Date: Tue, 15 Jul 2025 08:53:44 +0200	[thread overview]
Message-ID: <175256242179.1778852.7497941633757904389.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250711090035.241160-1-c.ebner@proxmox.com>

On Fri, 11 Jul 2025 11:00:35 +0200, Christian Ebner wrote:
> The installer assumes to have a valid mac address for all interfaces
> as provided by the runtime env json file. Deserialization will fail
> if this is not the case.
> 
> In some cases, the interface might however not provide a valid MAC
> address, for example the WWAN LTE module without any SIM installed on
> some laptops.
> 
> [...]

Agreeing with your assesment in the reply to v3, so applied this one, thanks!

[1/1] run-env: filter out interfaces without valid mac address
      commit: aff57231b3bf18d778deb9ff596aeb1b79048ecf


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-07-15  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  9:00 [pve-devel] " Christian Ebner
2025-07-11 15:36 ` [pve-devel] superseded: " Christian Ebner
2025-07-15  6:53 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175256242179.1778852.7497941633757904389.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal