From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH ifupdown2] d/patches: add patch for transparent handling of interface altnames
Date: Fri, 11 Jul 2025 20:09:04 +0200 [thread overview]
Message-ID: <175225734250.3641728.12541357287409887038.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250711162514.1929138-1-c.heiss@proxmox.com>
On Fri, 11 Jul 2025 18:25:12 +0200, Christoph Heiss wrote:
> tl;dr: add transparent altname support by caching links under their
> primary name as well as any potential altname, and translating all
> interface names from the config into the primary interface name.
>
> The structure makes it also as easy as possible to translate altnames in
> other corners of ifupdown2, if other cases should come up.
>
> [...]
The amount of code changes are fewer than I expected, and most of it reads
pretty straight forward. While I'd expect a few bugs for edge cases to pop up,
the underlying design is IMO sound and a bit of testing of common stuff did not
surface any issues.
So, applied, thanks!
Once the (release) dust settles it might be still worth to send a PR upstream,
even though upstream went a bit silent, it still might help others and one
never knows what wonders might happen ;-)
W.r.t the ports-condone-regex: I think keeping the current behavior is fine
for now, these attributes are not that wide spread and if they really just
affect reloads it won't trigger immediately after the first reboot after the
major upgrade, which is when the interface renaming is normally happening, so
admins get a chance to update these regexes then.
If we want to check them too the only sensible solution (without thinking this
through _that_ much though) would be to check if any of the interface names
match the regex, and if, ignore the respective interface.
[1/1] d/patches: add patch for transparent handling of interface altnames
commit: d8e620a81429b4a55c854676cd28354320c08b75
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-11 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 16:25 [pve-devel] " Christoph Heiss
2025-07-11 18:09 ` Thomas Lamprecht [this message]
2025-07-14 12:40 ` [pve-devel] applied: " Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175225734250.3641728.12541357287409887038.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox