From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC manager 3/3] fix #6094: api: acme: allow to get plugin info with Sys.Audit on /
Date: Wed, 07 May 2025 11:15:41 +0200 [thread overview]
Message-ID: <1746609148.q1r00y12mt.astroid@yuna.none> (raw)
In-Reply-To: <0c5bea7b-7e6b-4818-a40f-838c329b964e@proxmox.com>
On May 6, 2025 3:52 pm, Fiona Ebner wrote:
> Am 17.02.25 um 13:19 schrieb Daniel Kral:
>> Relax the required permissions to query the list of ACME plugins and
>> their configurations. Both API endpoints do only read the ACME plugins
>> configuration file but does not modify any system state.
>
> Can't there be secrets in there that should not leak? I.e. the plugin
> config file is in /etc/pve/priv, so I'm not sure this should be relaxed.
> Even if it doesn't modify the state, it might be too sensitive for
> Sys.Audit.
we could maybe do what we do in other index API calls, and restrict the
returned information in case Sys.Modify is missing? this would basically
entail stripping the 'data' option for DNS plugins (which might contain
credentials), everything else should not be sensitive AFAICT..
OTOH, I am not sure there's much benefit to it either ;)
the ACME API parts which are still root only are probably more
interesting cleanup targets!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-07 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 12:19 [pve-devel] [RFC manager 0/3] #fix 6094: relax permissions of informational api endpoints Daniel Kral
2025-02-17 12:19 ` [pve-devel] [RFC manager 1/3] fix #6094: api: apt: allow to get packages info with Sys.Audit Daniel Kral
2025-05-06 13:52 ` Fiona Ebner
2025-02-17 12:19 ` [pve-devel] [RFC manager 2/3] fix #6094: api: node HW: allow to get usb info with Sys.Audit on / Daniel Kral
2025-05-06 13:52 ` Fiona Ebner
2025-02-17 12:19 ` [pve-devel] [RFC manager 3/3] fix #6094: api: acme: allow to get plugin " Daniel Kral
2025-05-06 13:52 ` Fiona Ebner
2025-05-07 9:15 ` Fabian Grünbichler [this message]
2025-05-07 9:43 ` Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1746609148.q1r00y12mt.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal