From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend] refactor: remove unused files and address deprecated import
Date: Wed, 7 May 2025 10:07:19 +0200 [thread overview]
Message-ID: <174660522668.1453012.10576771667807132988.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250506082501.28185-1-s.shaji@proxmox.com>
On Tue, 06 May 2025 10:25:01 +0200, Shan Shaji wrote:
> This patch removes the `utils_web.dart` file, which contained a
> deprecated `dart:html` import. Flutter suggest using `package:web` [0].
> However this package is an external package [1] and are not included
> by default with flutter or dart.
>
> The `registerConsoleIframe` function had one usage inside the
> `PveConsoleWidget` , but since the widget is no longer being
> used, this patch deletes both the `utils_web.dart` and
> `pve_console_widget.dart` files.
>
> [...]
Applied, thanks!
[1/1] refactor: remove unused files and address deprecated import
commit: c2118d1f4d41a1a9a71a9314925b31158cca0c84
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-05-07 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 8:25 [pve-devel] " Shan Shaji
2025-05-07 8:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174660522668.1453012.10576771667807132988.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal