From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-network 1/4] subnet: dhcp: improve Net::IP usage
Date: Mon, 7 Apr 2025 18:42:42 +0200 [thread overview]
Message-ID: <174404413984.2984242.12749614220920020822.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250307125056.169575-1-s.hanreich@proxmox.com>
On Fri, 07 Mar 2025 13:50:53 +0100, Stefan Hanreich wrote:
> This simplifies the comparison of IPs by using the object-oriented
> interface over the procedural one. Also instantiate the ips using the
> new method rather than using new, which isn't a keyword in Perl. This
> fixes the respective perlcritic warning.
>
Applied, thanks!
[1/4] subnet: dhcp: improve Net::IP usage
commit: 1a698b27f4e959bb2b63b9393a2c223d32fea020
[2/4] subnet: dhcp: fix typo in error message
commit: e62b892fdc5d6b94d61af5424a6957983fbeeb29
[3/4] subnet: dhcp: only accept single ips and normalize them
commit: f5ad8efc4e5fadd24311c06afb2c93a0eb65a575
[4/4] subnet: dhcp: do not allow overlapping dhcp ranges
commit: 3a904729fdc1e0b6b52e404a56221304cb62c011
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-07 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 12:50 [pve-devel] " Stefan Hanreich
2025-03-07 12:50 ` [pve-devel] [PATCH pve-network 2/4] subnet: dhcp: fix typo in error message Stefan Hanreich
2025-03-07 12:50 ` [pve-devel] [PATCH pve-network 3/4] subnet: dhcp: only accept single ips and normalize them Stefan Hanreich
2025-03-07 12:50 ` [pve-devel] [PATCH pve-network 4/4] subnet: dhcp: do not allow overlapping dhcp ranges Stefan Hanreich
2025-04-07 15:37 ` [pve-devel] [PATCH pve-network 1/4] subnet: dhcp: improve Net::IP usage Hannes Duerr
2025-04-07 16:42 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174404413984.2984242.12749614220920020822.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal