public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead
@ 2024-12-13 19:45 lou lecrivain via pve-devel
  2025-04-07 15:50 ` Hannes Duerr
  2025-04-07 16:28 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: lou lecrivain via pve-devel @ 2024-12-13 19:45 UTC (permalink / raw)
  To: pve-devel; +Cc: lou lecrivain

[-- Attachment #1: Type: message/rfc822, Size: 4060 bytes --]

From: lou lecrivain <lou.lecrivain@wdz.de>
To: pve-devel@lists.proxmox.com
Subject: SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead
Date: Fri, 13 Dec 2024 20:45:37 +0100
Message-ID: <20241213194539.43105-2-lou.lecrivain@wdz.de>

From: Lou Lecrivain <lou.lecrivain@wdz.de>

Signed-off-by: lou lecrivain <lou.lecrivain@wdz.de>
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/Network/SDN/Vnets.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
index 45292e3..4e795f2 100644
--- a/src/PVE/Network/SDN/Vnets.pm
+++ b/src/PVE/Network/SDN/Vnets.pm
@@ -118,11 +118,10 @@ sub add_next_free_cidr {
 	    my $network = $subnet->{network};
 
 	    next if Net::IP::ip_get_version($network) != $ipversion || $ips->{$ipversion};
-	    next if !$subnet->{'dhcp-range'};
 	    $subnetcount++;
 
 	    eval {
-		$ip = PVE::Network::SDN::Subnets::add_next_free_ip($zone, $subnetid, $subnet, $hostname, $mac, $vmid, $skipdns, $dhcprange);
+		$ip = PVE::Network::SDN::Subnets::add_next_free_ip($zone, $subnetid, $subnet, $hostname, $mac, $vmid, $skipdns, $subnet->{'dhcp-range'});
 	    };
 	    die $@ if $@;
 
-- 
2.47.0



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead
  2024-12-13 19:45 [pve-devel] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead lou lecrivain via pve-devel
@ 2025-04-07 15:50 ` Hannes Duerr
  2025-04-07 16:28 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Hannes Duerr @ 2025-04-07 15:50 UTC (permalink / raw)
  To: Proxmox VE development discussion

Tested this patch and the 3 other patches which belong together [0]
Did not run into any issues.

[0] 
https://lore.proxmox.com/pve-devel/mailman.183.1734119197.332.pve-devel@lists.proxmox.com/

Please consider this

Tested-by: Hannes Duerr <h.duerr@proxmox.com>

On 12/13/24 20:45, lou lecrivain via pve-devel wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead
  2024-12-13 19:45 [pve-devel] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead lou lecrivain via pve-devel
  2025-04-07 15:50 ` Hannes Duerr
@ 2025-04-07 16:28 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-04-07 16:28 UTC (permalink / raw)
  To: pve-devel

On Fri, 13 Dec 2024 20:45:37 +0100, lou lecrivain via pve-devel wrote:
> 


Applied, thanks!

[1/1] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead
      commit: 7603197666df54d15ece0deb9d55e427b8aca850


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-07 16:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-13 19:45 [pve-devel] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead lou lecrivain via pve-devel
2025-04-07 15:50 ` Hannes Duerr
2025-04-07 16:28 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal