public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs
Date: Wed, 02 Apr 2025 15:17:58 +0200	[thread overview]
Message-ID: <1743599665.f3zigcahb8.astroid@yuna.none> (raw)
In-Reply-To: <20250304115803.194820-1-m.frank@proxmox.com>

other than the comments on individual patches nothing here jumped out at
me for the backend part, I haven't looked at the front-end.

some things that would be nice to consider/follow-up with:
- add a hotplug feature (set up all the machinery, even if no virtiofs
  is configured yet, then add/remove shares at runtime?)
- this would maybe allow removing shares before
  live-migrating/savevm-ing
- keep an eye on upstream live-migration support for shared backing dirs
- implement pve-container support via bind mounts

On March 4, 2025 12:57 pm, Markus Frank wrote:
> Virtio-fs is a shared file system that enables sharing a directory
> between host and guest VMs. It takes advantage of the locality of
> virtual machines and the hypervisor to get a higher throughput than
> the 9p remote file system protocol.
> 
> build-order:
> 1. cluster
> 2. guest-common
> 3. docs
> 4. qemu-server
> 5. manager
> 
> I did not get virtiofsd to run with run_command without creating
> zombie processes after stutdown. So I replaced run_command with exec
> for now. Maybe someone can find out why this happens.
> 
> 
> changes in v14:
> * disallow commas and equal signs in path until the path can be quoted
>  in property strings
> * addressed style nits and improved formatting
> * use max_virtiofs() in check_vm_create_dir_perm
> * removed unnecessary checks after parse_property_string
> * find_on_current_node returns only one entry
> * improved docs
> * added missing imports/uses
> 
> changes in v13:
> * removed acl/xattr attributes in node config
> * renamed acl/xattr in virtiofs qemu config to expose-acl/expose-xattr
> * renamed submounts in node config to announce-submounts
> * the "disable snapshot (with RAM) and hibernate with virtio-fs devices"
>  patch now uses the check_non_migratable_resources function
> * rewritten the part about announce-submounts in pve-docs patch
> 
> Changes in v12:
> * rebase to master as most patches could not be applied anymore
> 
> Changes in v11:
> * made submounts option on by default in WebUI and section config
> * PVE::QemuServer::Virtiofs dependency removed in QemuServer/Memory.pm
> * Minor changes to function/variable names
> * Disable snapshots (with RAM) and hibernate due to incompatibility
> 
> 
> 
> cluster:
> 
> Markus Frank (1):
>   add mapping/dir.cfg for resource mapping
> 
>  src/PVE/Cluster.pm  | 1 +
>  src/pmxcfs/status.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> 
> 
> guest-common:
> 
> Markus Frank (1):
>   add dir mapping section config
> 
>  src/Makefile           |   1 +
>  src/PVE/Mapping/Dir.pm | 196 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 197 insertions(+)
>  create mode 100644 src/PVE/Mapping/Dir.pm
> 
> 
> 
> docs:
> 
> Markus Frank (1):
>   add doc section for the shared filesystem virtio-fs
> 
>  qm.adoc | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 97 insertions(+), 2 deletions(-)
> 
> 
> 
> qemu-server:
> 
> Markus Frank (4):
>   control: add virtiofsd as runtime dependency for qemu-server
>   fix #1027: virtio-fs support
>   migration: check_local_resources for virtiofs
>   disable snapshot (with RAM) and hibernate with virtio-fs devices
> 
>  PVE/API2/Qemu.pm             |  41 ++++++-
>  PVE/QemuServer.pm            |  46 +++++++-
>  PVE/QemuServer/Makefile      |   3 +-
>  PVE/QemuServer/Memory.pm     |  22 ++--
>  PVE/QemuServer/Virtiofs.pm   | 211 +++++++++++++++++++++++++++++++++++
>  debian/control               |   1 +
>  test/MigrationTest/Shared.pm |   7 ++
>  7 files changed, 317 insertions(+), 14 deletions(-)
>  create mode 100644 PVE/QemuServer/Virtiofs.pm
> 
> 
> 
> manager:
> 
> Markus Frank (5):
>   api: add resource map api endpoints for directories
>   ui: add edit window for dir mappings
>   ui: add resource mapping view for directories
>   ui: form: add selector for directory mappings
>   ui: add options to add virtio-fs to qemu config
> 
>  PVE/API2/Cluster/Mapping.pm         |   7 +
>  PVE/API2/Cluster/Mapping/Dir.pm     | 308 ++++++++++++++++++++++++++++
>  PVE/API2/Cluster/Mapping/Makefile   |   1 +
>  www/manager6/Makefile               |   4 +
>  www/manager6/Utils.js               |   1 +
>  www/manager6/dc/Config.js           |  10 +
>  www/manager6/dc/DirMapView.js       |  42 ++++
>  www/manager6/form/DirMapSelector.js |  63 ++++++
>  www/manager6/qemu/HardwareView.js   |  19 ++
>  www/manager6/qemu/VirtiofsEdit.js   | 137 +++++++++++++
>  www/manager6/window/DirMapEdit.js   | 214 +++++++++++++++++++
>  11 files changed, 806 insertions(+)
>  create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm
>  create mode 100644 www/manager6/dc/DirMapView.js
>  create mode 100644 www/manager6/form/DirMapSelector.js
>  create mode 100644 www/manager6/qemu/VirtiofsEdit.js
>  create mode 100644 www/manager6/window/DirMapEdit.js
> 
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-04-02 13:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 11:57 Markus Frank
2025-03-04 11:57 ` [pve-devel] [PATCH cluster v14 1/12] add mapping/dir.cfg for resource mapping Markus Frank
2025-03-04 11:57 ` [pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config Markus Frank
2025-04-02 13:14   ` Fabian Grünbichler
2025-04-02 15:20     ` Markus Frank
2025-04-02 13:41   ` Daniel Kral
2025-03-04 11:57 ` [pve-devel] [PATCH docs v14 3/12] add doc section for the shared filesystem virtio-fs Markus Frank
2025-04-02 10:36   ` Laurențiu Leahu-Vlăducu
2025-04-02 13:13   ` Fabian Grünbichler
2025-04-02 13:44   ` Daniel Kral
2025-03-04 11:57 ` [pve-devel] [PATCH qemu-server v14 4/12] control: add virtiofsd as runtime dependency for qemu-server Markus Frank
2025-03-04 11:57 ` [pve-devel] [PATCH qemu-server v14 5/12] fix #1027: virtio-fs support Markus Frank
2025-04-02 13:13   ` Fabian Grünbichler
2025-03-04 11:57 ` [pve-devel] [PATCH qemu-server v14 6/12] migration: check_local_resources for virtiofs Markus Frank
2025-04-02 13:13   ` Fabian Grünbichler
2025-03-04 11:57 ` [pve-devel] [PATCH qemu-server v14 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices Markus Frank
2025-03-04 11:57 ` [pve-devel] [PATCH manager v14 08/12] api: add resource map api endpoints for directories Markus Frank
2025-03-04 11:58 ` [pve-devel] [PATCH manager v14 09/12] ui: add edit window for dir mappings Markus Frank
2025-03-04 11:58 ` [pve-devel] [PATCH manager v14 10/12] ui: add resource mapping view for directories Markus Frank
2025-04-02 10:36   ` Laurențiu Leahu-Vlăducu
2025-04-02 13:42   ` Daniel Kral
2025-03-04 11:58 ` [pve-devel] [PATCH manager v14 11/12] ui: form: add selector for directory mappings Markus Frank
2025-03-04 11:58 ` [pve-devel] [PATCH manager v14 12/12] ui: add options to add virtio-fs to qemu config Markus Frank
2025-04-02 10:36   ` Laurențiu Leahu-Vlăducu
2025-04-02 14:06     ` Daniel Kral
2025-04-02 13:42   ` Daniel Kral
2025-03-18  9:14 ` [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs Markus Frank
2025-04-02 10:36 ` Laurențiu Leahu-Vlăducu
2025-04-02 13:17 ` Fabian Grünbichler [this message]
2025-04-02 13:45 ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1743599665.f3zigcahb8.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal