public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox 1/2] notify: smtp: add missing 'tracing' namespace prefix
Date: Tue, 18 Mar 2025 11:48:44 +0100	[thread overview]
Message-ID: <1742294792.16ysbuzxgh.astroid@yuna.none> (raw)
In-Reply-To: <20241206101007.156910-1-l.wagner@proxmox.com>

this got fixed in a different fashion by Wolfgang:

https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=ddc154e5cdac9705b8ed232664a1e279a2e6f917

On December 6, 2024 11:10 am, Lukas Wagner wrote:
> This section of code is only compiled when the 'mail-forwarder' feature
> is enabled, which might have been the reason why this was missed when the
> other places where log messages are produced were migrated to 'tracing'.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  proxmox-notify/src/endpoints/smtp.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/proxmox-notify/src/endpoints/smtp.rs b/proxmox-notify/src/endpoints/smtp.rs
> index 6bb2d2d0..86911f9b 100644
> --- a/proxmox-notify/src/endpoints/smtp.rs
> +++ b/proxmox-notify/src/endpoints/smtp.rs
> @@ -336,7 +336,7 @@ impl Endpoint for SmtpEndpoint {
>                                  let header = HeaderValue::new(name, value);
>                                  message.headers_mut().insert_raw(header);
>                              }
> -                            Err(e) => error!("could not set header: {e}"),
> +                            Err(e) => tracing::error!("could not set header: {e}"),
>                          }
>                      }
>                  }
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-03-18 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 10:10 Lukas Wagner
2024-12-06 10:10 ` [pve-devel] [PATCH proxmox-mail-forward 2/2] switch to proxmox-log Lukas Wagner
2024-12-06 10:40   ` Gabriel Goller
2024-12-06 12:07     ` Lukas Wagner
2025-03-18 10:48   ` Fabian Grünbichler
2025-03-19  9:39     ` Gabriel Goller
2024-12-06 10:20 ` [pve-devel] [PATCH proxmox 1/2] notify: smtp: add missing 'tracing' namespace prefix Gabriel Goller
2025-03-18 10:48 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1742294792.16ysbuzxgh.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal