From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab
Date: Thu, 12 Dec 2024 09:02:25 +0100 [thread overview]
Message-ID: <1733990401.0fyc1pmvxb.astroid@yuna.none> (raw)
In-Reply-To: <20241210151130.321984-1-g.goller@proxmox.com>
there is both a bugzilla entry for this, and a patch as well:
https://lore.proxmox.com/pve-devel/mailman.710.1713473387.450.pve-devel@lists.proxmox.com/
granted, both happened after Leo's initial patch below, but please still
coordinate/communicate with Johannes as well ;)
On December 10, 2024 4:11 pm, Gabriel Goller wrote:
> Show the ip/hwaddress of the network interfaces of containers in the summary
> tab of the container and in the network tab on a per-interface basis.
>
> This series was originally by Leo Nunner:
> https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/
>
> v2, thanks @Dominik:
> - show if ip is static or dynamic (dhcp)
> - show multiple ips per interface
> - refactor/reuse AgentIPView instead of adding ContainerIPView component
> - various other small improvements
>
> manager:
>
> Gabriel Goller (2):
> lxc: show dynamically assigned IPs in network tab
> guest: refactor and reuse AgentIPView for containers
>
> www/manager6/Makefile | 2 +-
> www/manager6/lxc/Network.js | 85 +++++++----
> www/manager6/panel/GuestStatusView.js | 139 +++++++++++++++++-
> www/manager6/panel/GuestSummary.js | 2 +-
> .../{qemu/AgentIPView.js => panel/IPView.js} | 78 ++--------
> 5 files changed, 213 insertions(+), 93 deletions(-)
> rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (59%)
>
>
> container:
>
> Gabriel Goller (1):
> api: return all addresses of an interface
>
> src/PVE/API2/LXC.pm | 35 +++++++++++++++++++++++++----------
> src/PVE/LXC.pm | 7 +++++--
> 2 files changed, 30 insertions(+), 12 deletions(-)
>
>
> Summary over all repositories:
> 7 files changed, 243 insertions(+), 105 deletions(-)
>
> --
> Generated by git-murpp 0.7.1
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-12 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 15:11 Gabriel Goller
2024-12-10 15:11 ` [pve-devel] [PATCH manager v2 1/3] lxc: show dynamically assigned IPs in " Gabriel Goller
2024-12-10 15:11 ` [pve-devel] [PATCH manager v2 2/3] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2024-12-10 15:11 ` [pve-devel] [PATCH container v2 3/3] api: return all addresses of an interface Gabriel Goller
2024-12-10 17:58 ` Thomas Lamprecht
2024-12-11 14:57 ` Maximiliano Sandoval
2024-12-12 8:02 ` Fabian Grünbichler [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-10 15:10 [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab Gabriel Goller
2024-12-10 15:12 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733990401.0fyc1pmvxb.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox