From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] applied: [RFC manager] triggers: add path-based trigger interest
Date: Tue, 12 Nov 2024 10:11:05 +0100 [thread overview]
Message-ID: <1731402541.su0wzxwzyn.astroid@yuna.none> (raw)
In-Reply-To: <2c3fccc0-d515-486d-b517-63efa9666ee8@proxmox.com>
On November 11, 2024 6:44 pm, Thomas Lamprecht wrote:
> Am 05.11.24 um 12:43 schrieb Fabian Grünbichler:
>> to avoid the need to mark every package shipping PVE-related perl code as
>> activating the explicit trigger. the explicit trigger can still be used for
>> packages that need to reload the API without shipping a perl module
>>
>> the explicit trigger activation can be dropped in PVE 9.0 in packages that ship
>> perl code, without a need for versioned dependencies.
>
> Not for the HA usecase.
the HA case could also switch over to this approach, if we want to
reload HA for all PVE perl modules.. if we only want it for a subset,
then yes, the/an explicit trigger is better :)
>>
>> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>> ---
>> Currently, the following packages ship perl modules in /usr/share/perl5/PVE,
>> but don't activate the explicit trigger:
>>
>> libpve-apiclient-perl libpve-cluster-perl libpve-notify-perl pve-cluster libpve-u2f-server-perl dab
>
> At least for libpve-notify-perl it might be nice to get a trigger so that HA
> get's restarted there too, most of the rest it would be rather superfluous for
> HA.
see above - the question is whether we want an explicit list of packages
that trigger HA (and risk that it runs out of sync with the modules the
HA actually uses), or whether we want to treat HA like the pve-manager
services, and just let it reload on any perl module changes that *could*
affect it..
if desired, I can send a similar patch for pve-ha-manager as well.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-12 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 11:43 [pve-devel] " Fabian Grünbichler
2024-11-11 17:44 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-12 9:11 ` Fabian Grünbichler [this message]
2024-11-12 9:52 ` Thomas Lamprecht
2024-11-12 10:28 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1731402541.su0wzxwzyn.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox