[pve-devel] [PATCH manager] ui: allow decompressing ISO compressed with bz2

[pve-devel] [PATCH manager] ui: allow decompressing ISO compressed with bz2

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

This is a follow-up of the patch:

    [PATCH storage] storage: add bzip2 support

which can be found at [1].

[1] https://lists.proxmox.com/pipermail/pve-devel/2024-August/065030.html


 www/manager6/window/DownloadUrlToStorage.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
index 5523a152..9cd44d5c 100644
--- a/www/manager6/window/DownloadUrlToStorage.js
+++ b/www/manager6/window/DownloadUrlToStorage.js
@@ -84,7 +84,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
 		    let filename = data.filename || "";
 		    let compression = '__default__';
 		    if (view.content === 'iso') {
-			const matches = filename.match(/^(.+)\.(gz|lzo|zst)$/i);
+			const matches = filename.match(/^(.+)\.(gz|lzo|zst|bz2)$/i);
 			if (matches) {
 			    filename = matches[1];
 			    compression = matches[2].toLowerCase();
@@ -228,6 +228,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
 				['lzo', 'LZO'],
 				['gz', 'GZIP'],
 				['zst', 'ZSTD'],
+				['bz2', 'bzip2'],
 		    ],
 		    cbind: {
 			hidden: get => get('content') !== 'iso',
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: allow decompressing ISO compressed with bz2

[Aaron Lauterer]

Tested in combination with the adjacent backend patch [0] by Downloading 
a bz2 compressed ISO and booting a VM from it.

One small style nit inline, but I don't think that warants a new 
version, as we can fix it in a follow up or just directly when applying 
the patch.

[0] 
https://lore.proxmox.com/pve-devel/d92e4078-00bf-48ad-9be8-afaeaf7398be@proxmox.com/T/#m6cff68830fd5356ebddfff8cee7f4b8c7d7770bd

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2024-08-02  16:37, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> This is a follow-up of the patch:
> 
>      [PATCH storage] storage: add bzip2 support
> 
> which can be found at [1].
> 
> [1] https://lists.proxmox.com/pipermail/pve-devel/2024-August/065030.html
> 
> 
>   www/manager6/window/DownloadUrlToStorage.js | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
> index 5523a152..9cd44d5c 100644
> --- a/www/manager6/window/DownloadUrlToStorage.js
> +++ b/www/manager6/window/DownloadUrlToStorage.js
> @@ -84,7 +84,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
>   		    let filename = data.filename || "";
>   		    let compression = '__default__';
>   		    if (view.content === 'iso') {
> -			const matches = filename.match(/^(.+)\.(gz|lzo|zst)$/i);
> +			const matches = filename.match(/^(.+)\.(gz|lzo|zst|bz2)$/i);
>   			if (matches) {
>   			    filename = matches[1];
>   			    compression = matches[2].toLowerCase();
> @@ -228,6 +228,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
>   				['lzo', 'LZO'],
>   				['gz', 'GZIP'],
>   				['zst', 'ZSTD'],
> +				['bz2', 'bzip2'],

All the other options in the list are all-caps. We probably want this 
also to be BZIP2 to not break the overall theme here.

>   		    ],
>   		    cbind: {
>   			hidden: get => get('content') !== 'iso',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] ui: allow decompressing ISO compressed with bz2

[Fabian Grünbichler]

with Aaron's T-b/R-b

On August 2, 2024 4:37 pm, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> This is a follow-up of the patch:
> 
>     [PATCH storage] storage: add bzip2 support
> 
> which can be found at [1].
> 
> [1] https://lists.proxmox.com/pipermail/pve-devel/2024-August/065030.html
> 
> 
>  www/manager6/window/DownloadUrlToStorage.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
> index 5523a152..9cd44d5c 100644
> --- a/www/manager6/window/DownloadUrlToStorage.js
> +++ b/www/manager6/window/DownloadUrlToStorage.js
> @@ -84,7 +84,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
>  		    let filename = data.filename || "";
>  		    let compression = '__default__';
>  		    if (view.content === 'iso') {
> -			const matches = filename.match(/^(.+)\.(gz|lzo|zst)$/i);
> +			const matches = filename.match(/^(.+)\.(gz|lzo|zst|bz2)$/i);
>  			if (matches) {
>  			    filename = matches[1];
>  			    compression = matches[2].toLowerCase();
> @@ -228,6 +228,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
>  				['lzo', 'LZO'],
>  				['gz', 'GZIP'],
>  				['zst', 'ZSTD'],
> +				['bz2', 'bzip2'],
>  		    ],
>  		    cbind: {
>  			hidden: get => get('content') !== 'iso',
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel