public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate
Date: Thu, 31 Oct 2024 13:34:58 +0100	[thread overview]
Message-ID: <1730376856.afm8la86wu.astroid@yuna.none> (raw)
In-Reply-To: <20241030134402.310205-1-m.sandoval@proxmox.com>

On October 30, 2024 2:44 pm, Maximiliano Sandoval wrote:
> The function internally calls
> PVE::Certificate::get_certificate_fingerprint which in turn calls:
> 
> ```
>     my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
> ```
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  PVE/API2/Nodes.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index e8ff6dd9..1db148af 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -2567,7 +2567,7 @@ __PACKAGE__->register_method ({
>  		    renderer => 'duration',
>  		},
>  		ssl_fingerprint => {
> -		    description => "The SSL fingerprint for the node certificate.",
> +		    description => "The SSL SHA-256 fingerprint for the node certificate.",

what is an "SSL SHA-256 fingerprint"? the original was already bad, but
this made it worse..

the standard option has "Certificate SHA 256 fingerprint" as
description, IMHO that would already be quite okay here? after all, if
there is only a single fingerprint returned per node, it's quite clear
which certificate it belongs to?

or if you want to make it more specific, then use something like

"The SHA-256 fingerprint of the node's TLS certificate"

>  		    type => 'string',
>  		    optional => 1,
>  		},
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-10-31 12:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 13:44 Maximiliano Sandoval
2024-10-30 13:44 ` [pve-devel] [PATCH manager 2/2] api: node: index: use standard fingerprint-sha256 option Maximiliano Sandoval
2024-10-30 13:58   ` Maximiliano Sandoval
2024-10-31 12:34 ` Fabian Grünbichler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-10-30 12:18 [pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate Maximiliano Sandoval
2024-10-30 12:51 ` Fabian Grünbichler
2024-10-30 13:35   ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1730376856.afm8la86wu.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal