From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server] remote migration: fix online migration via API clients
Date: Tue, 03 Sep 2024 11:37:48 +0200 [thread overview]
Message-ID: <1725356019.j6qd6dvcqg.astroid@yuna.none> (raw)
In-Reply-To: <20240813084257.12720-1-f.ebner@proxmox.com>
On August 13, 2024 10:42 am, Fiona Ebner wrote:
> As reported in the community forum [0], when a remote migration
> request comes in via an API client, the -T flag for Perl is set, so an
> insecure dependency in a call like unlink() in forward_unix_socket()
> will fail with:
>
>> failed to write forwarding command - Insecure dependency in unlink while running with -T switch
>
> To fix it, untaint the problematic socket addresses coming from the
> remote side. Require that all sockets are below '/run/qemu-server/'
> and end with '.migrate'. This allows extensions in the future while
> still being quite strict.
>
> [0]: https://forum.proxmox.com/threads/123048/post-691958
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v2:
> * rule out '../' in path
>
> PVE/QemuMigrate.pm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index e71face4..d31589e7 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -1095,7 +1095,10 @@ sub phase2 {
> die "only UNIX sockets are supported for remote migration\n"
> if $tunnel_info->{proto} ne 'unix';
>
> - my $remote_socket = $tunnel_info->{addr};
> + # untaint
> + my ($remote_socket) =
> + $tunnel_info->{addr} =~ m|^(/run/qemu-server/(?:(?!\.\./).)+\.migrate)$|;
should we just switch to `\d+`, like we do for regular migration? in
phase2_start_local_cluster we have:
elsif ($line =~ m!^migration listens on (unix):(/run/qemu-server/(\d+)\.migrate)$!) {
$tunnel_info->{addr} = $2;
die "Destination UNIX sockets VMID does not match source VMID" if $vmid ne $3;
$tunnel_info->{proto} = $1;
}
and I don't really see a reason to deviate from that scheme any time
soon?
> + die "unexpected socket address '$tunnel_info->{addr}'\n" if !$remote_socket;
> my $local_socket = $remote_socket;
> $local_socket =~ s/$remote_vmid/$vmid/g;
> $tunnel_info->{addr} = $local_socket;
> @@ -1104,6 +1107,9 @@ sub phase2 {
> PVE::Tunnel::forward_unix_socket($self->{tunnel}, $local_socket, $remote_socket);
>
> foreach my $remote_socket (@{$tunnel_info->{unix_sockets}}) {
> + # untaint
> + ($remote_socket) = $remote_socket =~ m|^(/run/qemu-server/(?:(?!\.\./).)+\.migrate)$|
> + or die "unexpected socket address '$remote_socket'\n";
> my $local_socket = $remote_socket;
> $local_socket =~ s/$remote_vmid/$vmid/g;
> next if $self->{tunnel}->{forwarded}->{$local_socket};
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-03 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 8:42 Fiona Ebner
2024-09-03 9:37 ` Fabian Grünbichler [this message]
2024-09-04 11:14 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1725356019.j6qd6dvcqg.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox