From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 1/2] schema: vga: mention that type 'cirrus' should not be used
Date: Thu, 04 Jul 2024 13:57:00 +0200 [thread overview]
Message-ID: <172009422086.180658.17349021001496192544@yuna.proxmox.com> (raw)
In-Reply-To: <20240531151330.106977-1-f.ebner@proxmox.com>
Quoting Fiona Ebner (2024-05-31 17:13:29)
> [0]: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/
> [1]: https://lore.kernel.org/qemu-devel/usd6hvncbao47zklcb5qlpvjcuk7odryu57f45imxienyltlec@2ujm6g2gr2od/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 5df0c96d..cf593383 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -179,7 +179,7 @@ my $agent_fmt = {
>
> my $vga_fmt = {
> type => {
> - description => "Select the VGA type.",
> + description => "Select the VGA type. Using type 'cirrus' is not recommended.",
> type => 'string',
> default => 'std',
> optional => 1,
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-04 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 15:13 [pve-devel] " Fiona Ebner
2024-05-31 15:13 ` [pve-devel] [PATCH qemu-server 2/2] cfg2cmd: split out helper for vga properties Fiona Ebner
2024-07-04 11:57 ` [pve-devel] applied: " Fabian Grünbichler
2024-07-04 11:57 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172009422086.180658.17349021001496192544@yuna.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox