From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] api: snapshot create/delete/rollback: print log line that mentions snapshot name
Date: Wed, 29 May 2024 13:28:19 +0200 [thread overview]
Message-ID: <1716982009.12ngpvad63.astroid@yuna.none> (raw)
In-Reply-To: <ecf42fea-b04b-4cc8-b496-5305d219c303@proxmox.com>
On May 29, 2024 1:07 pm, Dominik Csapak wrote:
> On 5/29/24 12:09, Fabian Grünbichler wrote:
>> On May 29, 2024 11:20 am, Dominik Csapak wrote:
>>> so that an admin can see from the task logs which snapshot was rolled
>>> back/created/removed without the need to look into the journal (to which
>>> the admin might not have access to).
>>
>> good idea in general, but wouldn't it be better to log it before
>> attempting the operation, so that the context is in the task log
>> irrespective of how a potential error message looks like?
>
> i'd probably log both
logging the end doesn't give you much (if the name is mentioned earlier
already), since the task already has a status, so it's (heavily) implied
;) but it also doesn't really hurt :)
>> (side note, we might want to think about making the whole snapshot
>> process a bit more verbose? i.e., log the individual parts as well?)
>
> i noticed that i missed doing that for containers .
> also for some storages there is already output (e.g. ceph logs the
> snapshot progress)
>
> For a v2 i'd do the logging in 'snapshot_create' etc. in AbstractConfig,
> that should handle both vms and ct, and there we can print between
> phases too
>
> does that sound ok?
sure!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-29 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 9:20 Dominik Csapak
2024-05-29 10:09 ` Fabian Grünbichler
2024-05-29 11:07 ` Dominik Csapak
2024-05-29 11:28 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1716982009.12ngpvad63.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox