Re: [pve-devel] [PATCH many 00/19] notifications: move template strings to template files; PBS preparations

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On April 19, 2024 12:09 pm, Fiona Ebner wrote:
> Am 09.04.24 um 15:25 schrieb Lukas Wagner:
>> Bumps/dependencies:
>>   - proxmox_notify
>>       - libproxmox-rs-perl/libpve-rs-perl (needs bumped proxmox_notify)
>>           - libpve-notify-perl  (needs bumped libproxmox-rs-perl/libpve-rs-perl)
>>               - pve-ha-manager (needs bumped libpve-notify-perl)
>>               - pve-manager (needs bumped libpve-notify-perl)
>>       - proxmox-mail-forward (optional. should not be affected by any changes, but I think
>>         it should be also be bumped for any larger proxmox_notify changes to avoid any
>>         weird hidden regressions due to mismatches of proxmox_notify
>> 
> 
> Versioned breaks required:
> - new pve-cluster will break old pve-manager and old pve-ha-manager
> - new libproxmox-rs-perl/libpve-rs-perl will break old pve-cluster
> 
> Still not too sure about putting the templates in
> /usr/share/proxmox-ve/, but maybe @Thomas or @Fabian can chime in on that.

without in-depth look at all the changes in this series, I think it
would make most sense for the package shipping (most?) templates to
"own" the dir where they are shipped. that seems to be pve-manager, so
maybe /usr/share/pve-manager would be an okay fit?

or, if we want to avoid having "pve-manager" there, we could of course
also create /usr/share/pve or /usr/lib/pve or one of those with
"proxmox" instead of "pve", and have that owned by pve-manager..

I dislike proxmox-ve
- it might not be the case that it is always installed, which means
  potential pitfalls for such non-standard systems or if we ever make it
  optional like we did for PMG/PBS (granted, not very likely, but
  still..)
- normally the /usr/share/$package dir should only be used by $package


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel