[pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[Hannes Laimer]

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---

came up in enterprise support, and I don't think there is a reason to
not have it in the UI, while having it in the API

v2:
 - use Aaron's improved help text

 www/manager6/storage/DirEdit.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 3e2025fc..4d1921dc 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
 	    },
 	];
 
+	me.advancedColumn2 = [
+	    {
+		xtype: 'proxmoxcheckbox',
+		name: 'is_mountpoint',
+		uncheckedValue: 0,
+		fieldLabel: gettext('Mountpoint'),
+		autoEl: {
+		    tag: 'div',
+		    'data-qtip': gettext('Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.'),
+		},
+	    },
+	];
 	me.callParent();
     },
 });
-- 
2.39.2

Re: [pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[Fiona Ebner]

Am 23.02.24 um 13:03 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
> 
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
> 

This rationale could/should become the commit message, i.e. the fact
that having it in the UI is convenient for many users.

The plugin for BTRFS also supports this option. I think it makes sense
adding it there too. Could even be done in storage/Base.js like for
preallocation, but as long as there is no third plugin with the option,
duplication is also fine IMHO.

Re: [pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

[Fabian Grünbichler]

On February 23, 2024 1:03 pm, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> 
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
> 
> v2:
>  - use Aaron's improved help text
> 
>  www/manager6/storage/DirEdit.js | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> index 3e2025fc..4d1921dc 100644
> --- a/www/manager6/storage/DirEdit.js
> +++ b/www/manager6/storage/DirEdit.js
> @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
>  	    },
>  	];
>  
> +	me.advancedColumn2 = [
> +	    {
> +		xtype: 'proxmoxcheckbox',

this isn't a boolean value though, but a string that has a special
interpretation when its value is a boolean.. this would need at least
read-only support for the "contains a path" case, else it breaks the
config entry (resetting to it not being treated as mountpoint!) when
doing unrelated edits via the UI..

> +		name: 'is_mountpoint',
> +		uncheckedValue: 0,
> +		fieldLabel: gettext('Mountpoint'),
> +		autoEl: {
> +		    tag: 'div',
> +		    'data-qtip': gettext('Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.'),
> +		},
> +	    },
> +	];
>  	me.callParent();
>      },
>  });
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
>