* [pve-devel] [PATCH qemu-server] api: fix using import-from with SCSI disks
@ 2024-01-31 10:53 Fiona Ebner
2024-01-31 11:34 ` [pve-devel] applied: " Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2024-01-31 10:53 UTC (permalink / raw)
To: pve-devel
by fixing the SCSI feature compatibility check helper. The helper is
also called for disks using import-from, so it has to use the extended
schema when parsing the drive.
Fixes: d1feab4a ("fix #4957: add vendor and product information passthrough for SCSI-Disks")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index cdc8f7ac..69c5896a 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -699,7 +699,7 @@ my $check_vm_modify_config_perm = sub {
sub assert_scsi_feature_compatibility {
my ($opt, $conf, $storecfg, $drive_attributes) = @_;
- my $drive = PVE::QemuServer::Drive::parse_drive($opt, $drive_attributes);
+ my $drive = PVE::QemuServer::Drive::parse_drive($opt, $drive_attributes, 1);
my $machine_type = PVE::QemuServer::get_vm_machine($conf, undef, $conf->{arch});
my $machine_version = PVE::QemuServer::Machine::extract_version(
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] api: fix using import-from with SCSI disks
2024-01-31 10:53 [pve-devel] [PATCH qemu-server] api: fix using import-from with SCSI disks Fiona Ebner
@ 2024-01-31 11:34 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2024-01-31 11:34 UTC (permalink / raw)
To: Proxmox VE development discussion
On January 31, 2024 11:53 am, Fiona Ebner wrote:
> by fixing the SCSI feature compatibility check helper. The helper is
> also called for disks using import-from, so it has to use the extended
> schema when parsing the drive.
>
> Fixes: d1feab4a ("fix #4957: add vendor and product information passthrough for SCSI-Disks")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index cdc8f7ac..69c5896a 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -699,7 +699,7 @@ my $check_vm_modify_config_perm = sub {
> sub assert_scsi_feature_compatibility {
> my ($opt, $conf, $storecfg, $drive_attributes) = @_;
>
> - my $drive = PVE::QemuServer::Drive::parse_drive($opt, $drive_attributes);
> + my $drive = PVE::QemuServer::Drive::parse_drive($opt, $drive_attributes, 1);
>
> my $machine_type = PVE::QemuServer::get_vm_machine($conf, undef, $conf->{arch});
> my $machine_version = PVE::QemuServer::Machine::extract_version(
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-31 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-31 10:53 [pve-devel] [PATCH qemu-server] api: fix using import-from with SCSI disks Fiona Ebner
2024-01-31 11:34 ` [pve-devel] applied: " Fabian Grünbichler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox