From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] api: fix using import-from with SCSI disks
Date: Wed, 31 Jan 2024 12:34:38 +0100 [thread overview]
Message-ID: <1706700870.hhqx404h2g.astroid@yuna.none> (raw)
In-Reply-To: <20240131105400.19813-1-f.ebner@proxmox.com>
On January 31, 2024 11:53 am, Fiona Ebner wrote:
> by fixing the SCSI feature compatibility check helper. The helper is
> also called for disks using import-from, so it has to use the extended
> schema when parsing the drive.
>
> Fixes: d1feab4a ("fix #4957: add vendor and product information passthrough for SCSI-Disks")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index cdc8f7ac..69c5896a 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -699,7 +699,7 @@ my $check_vm_modify_config_perm = sub {
> sub assert_scsi_feature_compatibility {
> my ($opt, $conf, $storecfg, $drive_attributes) = @_;
>
> - my $drive = PVE::QemuServer::Drive::parse_drive($opt, $drive_attributes);
> + my $drive = PVE::QemuServer::Drive::parse_drive($opt, $drive_attributes, 1);
>
> my $machine_type = PVE::QemuServer::get_vm_machine($conf, undef, $conf->{arch});
> my $machine_version = PVE::QemuServer::Machine::extract_version(
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2024-01-31 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 10:53 [pve-devel] " Fiona Ebner
2024-01-31 11:34 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1706700870.hhqx404h2g.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox