From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v4 1/2] migration: secure and use source volume names for deactivation
Date: Tue, 30 Jan 2024 10:42:30 +0100 [thread overview]
Message-ID: <1706607727.ezgarw8lmv.astroid@yuna.none> (raw)
In-Reply-To: <20231219140306.188937-2-h.duerr@proxmox.com>
thanks!
On December 19, 2023 3:03 pm, Hannes Duerr wrote:
> During migration, the volume names may change if the name is already in
> use at the target location. We therefore want to save the original names
> so that we can deactivate the original volumes afterwards.
>
> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
> PVE/QemuMigrate.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index b87e47a..8d9b35a 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -1455,6 +1455,8 @@ sub phase3_cleanup {
>
> my $tunnel = $self->{tunnel};
>
> + my $sourcevollist = PVE::QemuServer::get_vm_volumes($conf);
> +
> if ($self->{volume_map} && !$self->{opts}->{remote}) {
> my $target_drives = $self->{target_drive};
>
> @@ -1586,8 +1588,7 @@ sub phase3_cleanup {
>
> # always deactivate volumes - avoid lvm LVs to be active on several nodes
> eval {
> - my $vollist = PVE::QemuServer::get_vm_volumes($conf);
> - PVE::Storage::deactivate_volumes($self->{storecfg}, $vollist);
> + PVE::Storage::deactivate_volumes($self->{storecfg}, $sourcevollist);
> };
> if (my $err = $@) {
> $self->log('err', $err);
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2024-01-30 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:03 [pve-devel] [PATCH qemu-server/storage v4 0/2] fix #1611: implement import of base-images for LVM-thin Storage Hannes Duerr
2023-12-19 14:03 ` [pve-devel] [PATCH qemu-server v4 1/2] migration: secure and use source volume names for deactivation Hannes Duerr
2024-01-30 9:42 ` Fabian Grünbichler [this message]
2023-12-19 14:03 ` [pve-devel] [PATCH pve-storage v4 2/2] fix #1611: implement import of base-images for LVM-thin Storage Hannes Duerr
2023-12-19 14:10 ` Lukas Wagner
2024-01-30 10:00 ` Fabian Grünbichler
2024-04-10 8:55 ` Hannes Dürr
2024-04-18 13:24 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1706607727.ezgarw8lmv.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox