From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH storage 2/2] plugin schema: improve description of 'nodes' property
Date: Tue, 30 Jan 2024 10:38:56 +0100 [thread overview]
Message-ID: <1706607501.n4ap98ejyf.astroid@yuna.none> (raw)
In-Reply-To: <20231004073541.104105-2-f.ebner@proxmox.com>
applied this on already, thanks!
On October 4, 2023 9:35 am, Fiona Ebner wrote:
> The default description doesn't make it clear what the property is
> used for in the context of storages.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Storage/Plugin.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index dc89d13..953b785 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -138,7 +138,10 @@ my $defaultData = {
> type => { description => "Storage type." },
> storage => get_standard_option('pve-storage-id',
> { completion => \&PVE::Storage::complete_storage }),
> - nodes => get_standard_option('pve-node-list', { optional => 1 }),
> + nodes => get_standard_option('pve-node-list', {
> + description => "List of nodes for which the storage configuration applies.",
> + optional => 1,
> + }),
> content => {
> description => "Allowed content types.\n\nNOTE: the value " .
> "'rootdir' is used for Containers, and value 'images' for VMs.\n",
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2024-01-30 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 7:35 [pve-devel] [PATCH storage 1/2] plugin schema: improve description of 'shared' property Fiona Ebner
2023-10-04 7:35 ` [pve-devel] [PATCH storage 2/2] plugin schema: improve description of 'nodes' property Fiona Ebner
2024-01-30 9:38 ` Fabian Grünbichler [this message]
2024-01-16 12:22 ` [pve-devel] [PATCH storage 1/2] plugin schema: improve description of 'shared' property Fiona Ebner
2024-01-30 9:38 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1706607501.n4ap98ejyf.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox