From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 1/2] plugin schema: improve description of 'shared' property
Date: Tue, 30 Jan 2024 10:38:10 +0100 [thread overview]
Message-ID: <1706607182.44b896xnw8.astroid@yuna.none> (raw)
In-Reply-To: <20231004073541.104105-1-f.ebner@proxmox.com>
On October 4, 2023 9:35 am, Fiona Ebner wrote:
> It's not clear to users what this property does otherwise. Latest
> report from the community forum:
>
> https://forum.proxmox.com/threads/134393
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Storage/Plugin.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 815773b..dc89d13 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -167,7 +167,9 @@ my $defaultData = {
> default => "Unlimited for users with Datastore.Allocate privilege, 5 for other users",
> },
> shared => {
> - description => "Mark storage as shared.",
> + description => "Indicate that this is a single storage which is already accessible by "
> + ."all nodes (or all listed in the 'nodes' option). Will not make a local storage "
> + ."automatically accessible to other nodes!",
I am not sure the 'already' helps here if you don't already (heh) know
what 'shared' means. it also doesn't include that it means the same
contents on all nodes - a local storage is also accessible on all nodes
(or those listed in the 'nodes' option) after all, but it's not
shared/has different contents on each node ;)
maybe something like
Indicate that this storage has the same content on all nodes that can
access it. It will not automatically make a local storage shared, it
just marks already shared storages as such!
?
there's also content in pve-docs that would need to be harmonized after
such a change, e.g. the "common storage properties", but maybe also
other parts of pvesm.adoc
> type => 'boolean',
> optional => 1,
> },
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2024-01-30 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 7:35 Fiona Ebner
2023-10-04 7:35 ` [pve-devel] [PATCH storage 2/2] plugin schema: improve description of 'nodes' property Fiona Ebner
2024-01-30 9:38 ` [pve-devel] applied: " Fabian Grünbichler
2024-01-16 12:22 ` [pve-devel] [PATCH storage 1/2] plugin schema: improve description of 'shared' property Fiona Ebner
2024-01-30 9:38 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1706607182.44b896xnw8.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox