From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH cluster] cfs_write_file: fix accidental UTF-8 re-encoding
Date: Tue, 16 Jan 2024 11:24:03 +0100 [thread overview]
Message-ID: <1705400629.t4m75d74nr.astroid@yuna.none> (raw)
In-Reply-To: <20240109115507.44509-1-f.ebner@proxmox.com>
with Filip's T-B, thanks!
On January 9, 2024 12:55 pm, Fiona Ebner wrote:
> by correclty passing the $force_utf8 flag to
> PVE::Tools::file_set_contents(). The idea was that only callers that
> are ready will opt-in to the behavior.
>
> When reading files with PVE::Tools::file_get_contents() or
> ipcc_get_config(), the UTF-8 flag on the Perl string is not set, even
> if the data is UTF-8. Such data would then be encoded a second time,
> as reported in the community forum [0] and bug tracker [1].
>
> [0]: https://forum.proxmox.com/threads/139282/
> [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=1909#c1
>
> Fixes: 90c824b ("cluster fs: allow to force UTF-8 encoding for cfs_write_file")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Cluster.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
> index 4c828c1..f899dbe 100644
> --- a/src/PVE/Cluster.pm
> +++ b/src/PVE/Cluster.pm
> @@ -594,7 +594,7 @@ sub cfs_write_file {
> $ci->{version} = undef;
> }
>
> - PVE::Tools::file_set_contents($fsname, $raw, undef, 1);
> + PVE::Tools::file_set_contents($fsname, $raw, undef, $force_utf8);
> }
>
> my $cfs_lock = sub {
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2024-01-16 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 11:55 [pve-devel] " Fiona Ebner
2024-01-09 14:06 ` Filip Schauer
2024-01-16 10:24 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1705400629.t4m75d74nr.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox