From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC common 1/2] partially fix #4501: next unused port: bump port reservation expiretime
Date: Wed, 15 Nov 2023 09:51:24 +0100 [thread overview]
Message-ID: <1700038214.ir3qk5rhnu.astroid@yuna.none> (raw)
In-Reply-To: <20231114140204.27679-3-f.ebner@proxmox.com>
On November 14, 2023 3:02 pm, Fiona Ebner wrote:
> For QEMU migration via TCP, there's a bit of time between port
> reservation and usage, because currently, the port needs to be
> reserved before invoking a fork, where the systemd scope needs to be
> set up and swtpm might need to be started before the QEMU binary can
> be invoked and actually use the port.
>
> Not bumping too much, because mass migration with many small VMs might
> need to re-use the ports rather quickly (there's only 50 ports).
>
> The other two usages of the function are for VNC and SPICE, with
> 100 and 999 ports respectively. And for those, ports are usually used
> for longer than 30 seconds anyways, so the higher expire time should
> be fine.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
since it's an RFC:
Acked-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> src/PVE/Tools.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index b3af2c6..4d018e9 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -918,7 +918,7 @@ sub next_unused_port {
>
> my $code = sub {
>
> - my $expiretime = 5;
> + my $expiretime = 30;
> my $ctime = time();
>
> my $ports = {};
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2023-11-15 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 14:02 [pve-devel] [RFC qemu-server/common] fix #4501: improve port reservation for QEMU TCP migration Fiona Ebner
2023-11-14 14:02 ` [pve-devel] [RFC qemu-server 1/1] partially fix #4501: migration: start vm: move port reservation and usage closer together Fiona Ebner
2023-11-15 8:55 ` Fabian Grünbichler
2023-11-15 10:12 ` Wolfgang Bumiller
2023-11-15 10:22 ` Fiona Ebner
2023-11-15 11:21 ` Wolfgang Bumiller
2023-11-14 14:02 ` [pve-devel] [RFC common 1/2] partially fix #4501: next unused port: bump port reservation expiretime Fiona Ebner
2023-11-15 8:51 ` Fabian Grünbichler [this message]
2023-11-14 14:02 ` [pve-devel] [RFC common 2/2] fix #4501: next unused port: work around issue with too short expiretime Fiona Ebner
2023-11-14 14:13 ` Fiona Ebner
2023-11-15 8:51 ` Fabian Grünbichler
2023-11-15 10:16 ` Fiona Ebner
2023-11-15 10:27 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1700038214.ir3qk5rhnu.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox