From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Noel Ullreich <n.ullreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-widget-toolkit 2/2] increased language dropdown menu width
Date: Fri, 24 Mar 2023 12:27:51 +0100 [thread overview]
Message-ID: <16da1e8d-7f47-57f6-420b-a20b2ea60466@proxmox.com> (raw)
In-Reply-To: <20230323144425.113963-3-n.ullreich@proxmox.com>
Am 23/03/2023 um 15:44 schrieb Noel Ullreich:
> With the new translations and layout, the width of the dropdown menu
> needs to be increased so that the languages are all on the same line.
> This width might need to increased in the future if translations were to
> create a linebreak.
>
> Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
> ---
> src/window/LanguageEdit.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied first but then basically reverted it again and switched it out with
a patch [0] that only changes the width of picker, not the whole field, and
also reduces the field labelWidth from 100 px to 75 px, which is enough
for all translations here, to give the field a bit more space while keeping
our usual window size for such single/few parameter windows - thanks!
[0]: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=311fb72a272a2c66e611d08e1950cb756f245838
prev parent reply other threads:[~2023-03-24 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 14:44 [pve-devel] [PATCH pve-widget-toolkit 0/2] fix 4524: Language names should be translated Noel Ullreich
2023-03-23 14:44 ` [pve-devel] [PATCH pve-widget-toolkit 1/2] Translated language dropdown menu in web interface Noel Ullreich
2023-03-24 11:25 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-23 14:44 ` [pve-devel] [PATCH pve-widget-toolkit 2/2] increased language dropdown menu width Noel Ullreich
2023-03-24 11:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16da1e8d-7f47-57f6-420b-a20b2ea60466@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox