public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-manager] fix #5076: Added a field for OpenID audiences to the configuration UI
@ 2025-02-06 12:27 Alexander Abraham
  2025-02-17  9:00 ` Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Abraham @ 2025-02-06 12:27 UTC (permalink / raw)
  To: pve-devel; +Cc: Alexander Abraham

A field was added to the configuration prompt for
configuring audiences in OpenID realms.

Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
---
 www/manager6/dc/AuthEditOpenId.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
index 544c0de5..7942fa58 100644
--- a/www/manager6/dc/AuthEditOpenId.js
+++ b/www/manager6/dc/AuthEditOpenId.js
@@ -111,6 +111,15 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
 		deleteEmpty: '{!isCreate}',
 	    },
 	},
+	{
+	    xtype: 'proxmoxtextfield',
+	    name: 'aud',
+	    fieldLabel: gettext('Audiences'),
+	    submitEmpty: false,
+	    cbind: {
+		deleteEmpty: '{!isCreate}',
+	    },
+	},
     ],
 
     initComponent: function() {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH pve-manager] fix #5076: Added a field for OpenID audiences to the configuration UI
  2025-02-06 12:27 [pve-devel] [PATCH pve-manager] fix #5076: Added a field for OpenID audiences to the configuration UI Alexander Abraham
@ 2025-02-17  9:00 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2025-02-17  9:00 UTC (permalink / raw)
  To: Proxmox VE development discussion, Alexander Abraham

depending on what restrictions in the backend will be implemented,
we should add the same here, so users get immediate feedback
for wrong values

aside from that LGTM

On 2/6/25 13:27, Alexander Abraham wrote:
> A field was added to the configuration prompt for
> configuring audiences in OpenID realms.
> 
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>   www/manager6/dc/AuthEditOpenId.js | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
> index 544c0de5..7942fa58 100644
> --- a/www/manager6/dc/AuthEditOpenId.js
> +++ b/www/manager6/dc/AuthEditOpenId.js
> @@ -111,6 +111,15 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
>   		deleteEmpty: '{!isCreate}',
>   	    },
>   	},
> +	{
> +	    xtype: 'proxmoxtextfield',
> +	    name: 'aud',
> +	    fieldLabel: gettext('Audiences'),
> +	    submitEmpty: false,
> +	    cbind: {
> +		deleteEmpty: '{!isCreate}',
> +	    },
> +	},
>       ],
>   
>       initComponent: function() {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-17  9:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-06 12:27 [pve-devel] [PATCH pve-manager] fix #5076: Added a field for OpenID audiences to the configuration UI Alexander Abraham
2025-02-17  9:00 ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal