From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager v2 7/7] ui: qga: hide freeze-fs-on-backup conditionally
Date: Mon, 16 Mar 2026 22:37:15 +0100 [thread overview]
Message-ID: <16c96c98-2b0e-439c-877f-b0dd800b54cd@proxmox.com> (raw)
In-Reply-To: <20260313095534.79526-8-m.sandoval@proxmox.com>
Am 13.03.26 um 10:55 schrieb Maximiliano Sandoval:
> If the freeze-fs-on-backup key is not explicitly set on the config file
> or if it is explicitly enabled (which matches its default) we hide the
> corresponding checkbox and hint.
>
> Note that when the checkbox is unchecked we delete the value from the
> config. A consequence of this is that if the deprecated key is
> explicitly set `freeze-fs-on-backup=1`, we open the dialog, change some
> unrelated setting (so that the OK button becomes sensitive), press OK to
> save the settings, then the deprecated key freeze-fs-on-backup key would
> be gone from the config.
mostly description that I could see from the diff, which can be somewhat OK,
but really missing actual rationale here.
next prev parent reply other threads:[~2026-03-16 21:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 9:55 [PATCH manager v2 0/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 1/7] ui: utils: support guest-fsfreeze at render_qga_features Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 2/7] ui: qga: merge translatable string Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 3/7] ui: qga: move freeze-fs-on-backup to advanced opts Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 4/7] ui: qga: note that freeze-fs-on-backup is deprecated Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 5/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-03-16 21:41 ` Thomas Lamprecht
2026-03-13 9:55 ` [PATCH manager v2 6/7] ui: qga: call parameter me instead of this Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 7/7] ui: qga: hide freeze-fs-on-backup conditionally Maximiliano Sandoval
2026-03-16 21:37 ` Thomas Lamprecht [this message]
2026-03-16 15:29 ` applied: [PATCH manager v2 0/7] ui: qga: add checkbox for guest-fsfreeze Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c96c98-2b0e-439c-877f-b0dd800b54cd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox